search

cleidigh / printing-tools-ng

PrintingTools NG Thunderbird Extension - Printing Utilities
Other
35 stars 17 forks source link

Issues with Subject and attachments list in header for encrypted messages #242

Open cleidigh opened 7 months ago

cleidigh commented 7 months ago

See OP from @librelegal in

So there are two issues :

I need to setup for encryption so I can observe and test.

@cleidigh

cleidigh commented 7 months ago

@librelegal Thank you for the encrypted messages and attachments. Much easier to debug with real stuff. So I took a weekend hiatus from ietng to investigate.

On the subject header. It's interesting because the Subject is displayed in the message pane, tab and window. It is ellipsis in the header object and print preview. I don't have any access to the correct subject, however, tb manages to get it for the pane headers, odd.

As for the attachment list, I can and have fixed that. It turns out the web extension api for message attachments returns an empty array for encrypted messages. I have an alternate scrape method for eml messages that I can use instead. It works and I will file a bug.

I will post a test version for you. @cleidigh

cleidigh commented 7 months ago

@librelegal This test version fixes the attachment issue. https://github.com/cleidigh/printing-tools-ng/blob/v3.0.2-pgpt1/xpi/beta/printing-tools-ng-3.0.2-pgpt1-tb.xpi

@cleidigh

librelegal commented 7 months ago

I thank you a lot for providing a test version and that fast too.

You deserve the "miracle code cook badge": not only are attachments now shown with their name and appropriate icon in the print preview as well as in the actual paper print-out, they are also shown in emails with an encrypted subject line.

The subject line in emails with encrypted subject line visible on the screen is still only shown as three dots ("...") in preview and print, just like you said. In comparison that is much less important as in my experience with a large number of encrypted communications with a large number of different communication participants encrypted subject lines are used rarely and I completely avoid it where I can. Maybe you should not dive in this too deeply.

librelegal commented 7 months ago 
* Subject is … instead of the actual Subject (there is a TB bug https://bugzilla.mozilla.org/show_bug.cgi?id=184414)

The TB bug you refer to is not the relevant one I think. Relevant to that topic is this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1844149, see my report in #237

cleidigh commented 7 months ago

@librelegal I will gladly accept your "badge" %-) Once I get my touch up cleaning done in the repository I will spin up a true v3.0.2 branch with a beta for this. If I can get any movement on the Subject issue I will report. The error on the correct bug is noted. @cleidigh