Open kiki-ja opened 3 months ago
cleidigh
commented
3 months ago @kiki-ja You are quick! Thanks. Just posted b2 which should fix the Hide inline attachments issue. It was a bit tricky as it reloads the message. As for the other bugs noted:
kiki-ja
commented
3 months ago PTNG 3.1.0-b2 Thunderbird 128.0b3 64bit Windows 10 Pro 22H2 64bit
Just posted b2 which should fix the Hide inline attachments issue.
I have confirmed that it has been fixed.
@kiki-ja
kiki-ja
commented
3 months ago I have written a test report for "Position of header and footer lines" below. https://github.com/cleidigh/printing-tools-ng/issues/258#issuecomment-2199991652
@kiki-ja
kiki-ja
commented
3 months ago Add a test report. https://github.com/cleidigh/printing-tools-ng/issues/258#issuecomment-2212395654
@kiki-ja
kiki-ja
commented
2 months ago PTNG 3.1.0-b5 Thunderbird 128.0b6 64bit Windows 10 Pro 22H2 64bit
Test report: Unable to Print Preview messages in RSS feeds and unable to print in HTML.
Steps to Reproduce:
1.Select the message in the RSS feed.
2.Click Print Preview in PTNG.
3.When the message "Autosave or Cancel" appears, click "Cancel".
4.Nothing happens.
5.Click OK in 4. Autosave is executed, but the message is printed (output) in plain text.
Tested message file (.eml). sample message eml for test.zip
Question: This is the same in PTNG 3.0.1 + Thunderbird 115. Is this a specification?
@kiki-ja
cleidigh
commented
2 months ago @kiki-ja I just did a little ptng work today. I added the same Thunderbird blog feed as my existing github feed was just one liners. I tested and the preview was fine, however, I tested in Thunderbird v115 and v128, both previews worked. When I chose to save versus preview, it saved html, however, the images do not show. So something is there. @cleidigh
cleidigh
commented
2 months ago @kiki-ja I think the way the images are referenced in the Thunderbird blog is the problem. If I preview and print from the preview, everything prints correctly, ptng headers and the image, all html. If I print without the preview, the headers are there, but the image is replaced by the alt text. I cannot find any setting that changes this. I also can't find a native way to print without the preview so there is no comparison of a "good" native print without the preview. @cleidigh
kiki-ja
commented
2 months ago PTNG 3.1.0-b6 Thunderbird 128.0ESR 64bit Windows 10 Pro 22H2 64bit
This is a common report for RSS feed all messages.
A: PTNG Options -> PDF Output -> PDF File Naming -> Enable PDF Output Directory -> Check Off-> Print preview in PTNG Print preview of the PTNG did nothing. Click on the PTNG icon, also Ctrl+P gave similar results.
B: Check On -> Print preview in PTNG -> 'Click OK to Autosave PDF or Cancel to Preview' window opened No print preview after canceling. Click on the PTNG icon, also Ctrl+P gave similar results.
Is this a problem with my environment? Or is it a PTNG specification?
@kiki-ja
cleidigh
commented
2 months ago @kiki-ja I have been rushing on last minute ietng issues before release tomorrow. To clarify, You are saying this issue is ONLY with exporting all messages from an RSS feed account? Other accounts do not have this problem? Can you see and capture debug output? As soon as I get ietng out I will focus on ptng. @cleidigh
cleidigh
commented
2 months ago Sorry, obviously you meant a selected message. Just did a quick check with my Thunderbird rss feed. Both with and without pdf output directory enabled, the preview worked. So we have to figure out what is going on in your system. @cleidigh
kiki-ja
commented
2 months ago PTNG 3.1.0-b6 Thunderbird 128.0ESR 64bit Windows 10 Pro 22H2 64bit
Sorry again. The issue of not being able to select a message in the RSS feed, print preview and print it. I have attached a copy of the console log.
@kiki-ja
cleidigh
commented
2 months ago @kiki-ja So it's not finding the message pane. b7 has more debug. Use trace1in debug options. Before you copy debug, expand line 223, the document body. It's presumably some slight different view. Anything you can describe or do a screenshot might help. I have tried all the relevant views and they work for me. @cleidigh
kiki-ja
commented
2 months ago @cleidigh
b7 has more debug. Use trace1in debug options.
I tried to get the console log with trace1. I have attached a copy of the console log.
Before you copy debug, expand line 223, the document body. It's presumably some slight different view.
I could not see the difference.
I have installed and tested only PTNG with a new profile and I reproduce this problem. I am not sure if other users besides me are experiencing the same problem. If so, I will be in the clear.
@kiki-ja
cleidigh
commented
2 months ago @kiki-ja So the debug shows it fids the messagepane, but gets nothing for the contentDocument. Before you select all in the debug, click the little grey triangle for the browser object on line 223. This will show the entire object. b8 is posted. @cleidigh
cleidigh
commented
2 months ago Here is screenshot of my debug , notice expanded browser object
cleidigh
commented
2 months ago one other thing to try, do the same capture again, but with an imap message
cleidigh
commented
2 months ago @librelegal You can join the PTNG party if you wish %-) b8, just posted, has the fix for missing attachments table in headers with encrypted messages.. I tested it on my side, however, there was some problems with interactions with v128 updates so a second system test would be great. @cleidigh
kiki-ja
commented
2 months ago @cleidigh
PTNG 3.1.0-b8 Thunderbird 128.0ESR 64bit Windows 10 Pro 22H2 64bit
printingtoolsng-pengine.js:223:14 messagePaneBrowser final
I have attached a copy of the console log. console-log-223.zip
@kiki-ja
cleidigh
commented
2 months ago @kiki-ja This debug confirms that the contentDocument is null, that should point to the html of the selected message
containingShadowRoot: null contentDocument: null contentWindow: null contextMenu: "" controllers: XPCWrappedNative_NoHelper { QueryInterface: QueryInterface(), getControllerForCommand: getControllerForCommand(), insertControllerAt: insertControllerAt(), … }
The only thing I can think of is you are using a different view than I am. Can you get a screenshot of the whole Thunderbird window showing where you have the message selected? Without being on your computer and using the debugger, I may not be able to solve this, I just don't get it. @cleidigh
cleidigh
commented
2 months ago @kiki-ja In b9 I added advanced options help
kiki-ja
commented
2 months ago @cleidigh
Can you get a screenshot of the whole Thunderbird window showing where you have the message selected?
Attached is a screenshot of my entire Thunderbird window.
Without being on your computer and using the debugger, I may not be able to solve this, I just don't get it.
I suspect this problem is unique to my environment. Because I don't have the same reports from other users. So I give up trying to solve it.
@kiki-ja
cleidigh
commented
2 months ago @kiki-ja Honestly I am completely perplexed. Your view looks totally normal. Message list on top and message pane on the bottom. That matches everything we have done for some time. Frustrating... @cleidigh
kiki-ja
commented
2 months ago @cleidigh
I have emailed you the download link for the profile I am using for testing. It is a new profile with a POP dummy account and RSS feeds. Only the language packs (en-US, ja) are installed.
I have updated the help file. Attached.
@kiki-ja
PTNG 3.1.0-b1 Thunderbird 128.0b3 64bit Windows 10 Pro 22H2 64bit
I will test and report back if find any issues in the future.
@kiki-ja