search

cleishm / jsmockito

Javascript mocking framework inspired by the awesome mockito
http://jsmockito.org
Other
106 stars 19 forks source link

Sequence verifier #4

Closed EleotleCram closed 4 years ago

EleotleCram commented 13 years ago

Hi Chris,

This is the patch we've talked about in the mail. Just let me know if you can use it for jsmockito or if you need anything changed.

Kind regards,

__ Marcel

cleishm commented 13 years ago

Quick update: I haven't forgotten this. I'd like to review the API for sequences in general, just to make myself comfortable that it represents the best practice and doesn't depart too significantly from Mockito (given this is JsMockito). I'll do that as soon as I have some spare time, and then merge it into the next release.

EleotleCram commented 13 years ago

Hi Chris,

I understand your position (JsMockito being inspired by Mockito). Unfortunately I have a feeling that the guys over at Mockito have come up with an approach that is fairly limited. Our patch uses an approach that is inspired by google mock[1, 2]; we feel it is easier to understand, and much more flexible.

We'll understand (though regret it) if you cannot merge our patch into JsMockito because of its heritage (Mockito) and the approach to testing sequences that Mockito takes. Probably the best solution would be to convince the guys at Mockito to change their approach as well. But since that would start an API breaking discussion, it would probably take considerable resources (lots of diplomacy and time!). Unfortunately we don't have that amount of resources available.

Kind regards,

Marcel Toele

[1] http://code.google.com/p/googlemock/ [2] http://code.google.com/p/googlemock/wiki/CheatSheet#Expectation_Order

2011/8/17 chrisleishman reply@reply.github.com:

Quick update: I haven't forgotten this.  I'd like to review the API for sequences in general, just to make myself comfortable that it represents the best practice and doesn't depart too significantly from Mockito (given this is JsMockito).  I'll do that as soon as I have some spare time, and then merge it into the next release.

Reply to this email directly or view it on GitHub: https://github.com/chrisleishman/jsmockito/pull/4#issuecomment-1825165

jsdevel commented 11 years ago

What about #27? I think that would be more inline with Mockito and would allow sequence verification.

cleishm commented 4 years ago

If this is still valid, please feel free to reopen against the main branch.