cleitonlima / Neutrino

Programa para configuração do Fedora Linux

http://cleitonlima.com.br/neutrino

1 stars 0 forks source link

Possible error in base code #1

Closed gomex closed 13 years ago

gomex commented 13 years ago

Function chromium_repo has a error.

def chromium_repo():

Add Chromium Repo, from Fedora People

    system("gnome-terminal -e cd /etc/yum.repos.d;beesu yum localinstall http://repos.fedorapeople.org/repos/spot/chromium/fedora-chromium.repo")

It should have wget instead yum localinstall, because fedora-chromium is a repo file and not rpm.

Following the patch to fix that:

http://www.techfree.com.br/archive/0001-Fixed-bug-of-chromium_repo-function.patch

gomex commented 13 years ago

IMHO that function should be a separate module, because it is not a base code.

cleitonlima commented 13 years ago

Thanks for the observations. I applied yours patch to Chromium install module, with some changes. I accepted yours proposal and withdrew the installation of chromium from the API and placed it in a separate module.

I think this issue is solved.