clemenko / rke_airgap_install

a script/method for air gapping the Rancher Stack with Hauler
50 stars 25 forks source link

longhorn function does not respect longhorn version variable #4

Closed dmeiselman closed 1 year ago

dmeiselman commented 1 year ago

Hey Andy, found another bug for ya:

The longhorn function has 1.3.2.tgz hard coded. The latest tarball is named longhorn-1.4.0.tgz

clemenko commented 1 year ago

thanks. changing to helm upgrade -i longhorn /opt/rancher/helm/longhorn-$($LONGHORN_VERSION | sed 's/v//g').tgz --namespace longhorn-system --create-namespace --set ingress.enabled=true --set ingress.host=longhorn.$DOMAIN --set global.cattle.systemDefaultRegistry=localhost:5000

dmeiselman commented 1 year ago

ditto with rancher v2.7.0 at line 396

clemenko commented 1 year ago

good catch. found another. fixed. testing right now.

clemenko commented 1 year ago

all checks out.