clemente-lab / mmeds-meta

A database for storing and analyzing omics data
https://mmeds.org
2 stars 1 forks source link

Enhancement analysis testing #411

Closed mstapylton closed 2 years ago

mstapylton commented 2 years ago

Pull Request Template for MMEDS

What has changed

due to github weirdness, this never got merged

Checklist of pre-requisites

codecov[bot] commented 2 years ago

Codecov Report

Merging #411 (db49276) into master (779bc39) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #411   +/-   ##
=======================================
  Coverage   50.78%   50.78%           
=======================================
  Files          29       29           
  Lines        4988     4988           
=======================================
  Hits         2533     2533           
  Misses       2455     2455           
Flag Coverage Δ
server 49.65% <0.00%> (ø)
unit 15.49% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmeds/summary.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3789eb8...db49276. Read the comment docs.

mstapylton commented 2 years ago

This seems okay, but I'm pretty wary about merging this right before my big merge. What's the purpose of making these changes right now? Could it wait until after the other merge?

@adamcantor22 this was a fix that I thought you'd need to get tests passing, but maybe that's not the case. This was a fix for the fact that R in the jupyter env stopped working and as far as I could tell it was an issue with conda r-base. Maybe the issue with r-base got fixed. Anyway, given that in your branch tests are passing (test_analysis.py in particular) we actually don't need to merge this branch. I do want to keep the branch open just in case the problem recurs

adamcantor22 commented 2 years ago

Gotcha, sounds good