search

clemente-lab / mmeds-meta

A database for storing and analyzing omics data
https://mmeds.org
2 stars 1 forks source link

Issue fix consistent validation #421

Closed adamcantor22 closed 2 years ago

adamcantor22 commented 2 years ago

Pull Request Template for MMEDS

What has changed

Quick fixes to the bugs laid out in issue #420 . Per the text of that issue, this PR makes continuous variables allowed to be all unique, and makes the checking of duplicate barcodes and getting of demux stats to occur per-sequencing run. It also modifies test data slightly so that these things will all be checked when automated tests are run.

Checklist of pre-requisites

Additional notes

Closes #420

codecov[bot] commented 2 years ago

Codecov Report

Merging #421 (dff9c71) into master (02b1a87) will increase coverage by 0.12%. The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   57.94%   58.07%   +0.12%     
==========================================
  Files          30       30              
  Lines        5407     5421      +14     
==========================================
+ Hits         3133     3148      +15     
+ Misses       2274     2273       -1
Flag Coverage Δ
server 48.86% <63.63%> (+0.09%) :arrow_up:
unit 32.26% <96.96%> (+0.17%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmeds/validate.py 77.28% <95.45%> (+0.42%) :arrow_up:
mmeds/summary.py 79.27% <100.00%> (+0.18%) :arrow_up:
mmeds/util.py 53.60% <100.00%> (+0.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 02b1a87...dff9c71. Read the comment docs.