search

clementfarabet / gfx.js

A graphics backend for the browser (with a Torch7 client).
MIT License
125 stars 35 forks source link

fs.watch() unreliable #8

Open clementfarabet opened 10 years ago

clementfarabet commented 10 years ago

fs.watch apparently doesn't work on certain OSes, in particular OSX Snow Leopard. Should we rewrite part to have no dependence on fs.watch?

soumith commented 10 years ago

I think backward support is really tricky. Snow Leopard was quite a long ago.

soumith commented 10 years ago

The doc says:

You can still use fs.watchFile, which uses stat polling, but it is slower and less reliable.

I think that could be a fall-back without doing any big changes.

clementfarabet commented 10 years ago

OK makes sense

On Mon, May 19, 2014 at 12:05 PM, Soumith Chintala <notifications@github.com

wrote:

The doc says:

You can still use fs.watchFile, which uses stat polling, but it is slower and less reliable.

I think that could be a fall-back without doing any big changes.

— Reply to this email directly or view it on GitHubhttps://github.com/clementfarabet/gfx.js/issues/8#issuecomment-43523323 .

soumith commented 10 years ago

https://github.com/clementfarabet/gfx.js/pull/15 fixes this issue.