search

clementfarabet / lua---ffmpeg

An interface between ffmpeg and Lua/Torch
21 stars 17 forks source link

Map paramater syntax change #1

Closed jtbates closed 12 years ago

jtbates commented 12 years ago

The map parameter syntax is now '-map 0:stream_id' instead of '-map 0.stream_id'. I changed it to 0:v:stream_id to be sure we get a video stream and not an audio stream.

Reference: http://ffmpeg-users.933282.n4.nabble.com/Invalid-stream-specifier-0-Stream-map-0-0-matches-no-streams-Changes-in-FFMPEG-map-option-td4091165.html http://ffmpeg.org/ffmpeg.html#Advanced-options

jtbates commented 12 years ago

Do you want me to add code to check the version and issue the correct command so that both are supported?

jtbates commented 12 years ago

The ffmpeg commit that changed the syntax is 88bfe4518 http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=88bfe4518bc31a111023d5c7f0b54b17955a735e

Versions 0.9 and newer contain this change

clementfarabet commented 12 years ago

Hi JT,

before I merge this, I think it would be safer to actually check the ffmpeg version. Everybody has a different version of ffmpeg, it's a bit of a nightmare.

jtbates commented 12 years ago

Agreed. I'll see if I can get to this tomorrow.

jtbates commented 12 years ago

I think that should do it

clementfarabet commented 12 years ago

Cool, did you test it on Mac and Linux?

jtbates commented 12 years ago

Yes, ffmpeg 0.9 on MacOS and ffmpeg 0.8 on Ubuntu

clementfarabet commented 12 years ago

Cool just merged it.