search

clementgallet / libTAS

GNU/Linux software to (hopefully) give TAS tools to games
GNU General Public License v3.0
476 stars 56 forks source link

Loading a save state does not restore Deltarune combat to the correct state. #117

Closed BenLubar closed 5 years ago

BenLubar commented 5 years ago

Repro instructions (shouldn't need to be very accurate or even in frame advance mode to get this to work):

  1. Enter a fight in Deltarune.
  2. Save state
  3. Go to the ACT menu and move the cursor to a different option.
  4. Load state
  5. Go back to the ACT menu. Notice the cursor is still over the different option despite never having sent the input to cause that to the game.

This also affects RNG. For example, Hathy's heart outline attack will move in a different direction even if all of the inputs are identical.

qixils commented 5 years ago
  1. Install Deltarune natively

EDIT: can confirm, by the way.

InfamousKnight commented 5 years ago

Wait, he was using wine to run that? I didn’t know that worked at all.

qixils commented 5 years ago

no, he was using the natively installed deltarune. wine is not yet supported.

clementgallet commented 5 years ago

Should be fixed by a68e0211b304b9f4863733da2fdb9da9d1876904 , memset-ing when incremental savestate is disabled.

BenLubar commented 5 years ago

Whoops, thought I already closed this. The linked commit does indeed fix the problem.