clementine-player / Android-Remote

Control Clementine from your Android device
GNU General Public License v3.0
198 stars 80 forks source link

Override Files on download 1) shouldn't download the same file again 2) Delete old files #220

Open avimar opened 3 years ago

avimar commented 3 years ago

https://github.com/clementine-player/Android-Remote/blob/f0ffd3ed28c948f68ffa41c4ebcfa8c1deb09037/app/src/main/java/de/qspool/clementineremote/backend/downloader/ClementineSongDownloader.java#L346

Hi - I'm downloading my playlist and I enabled "override" hoping that it would sync my playlist, both adding new files and removing ones I've deleted.

I'm using Clementine on desktop and then I want offline access.

  1. But it seems if the file already exists it downloads it again, which can take quite a bit of time. It seems there's no check on this line for file equivalency. If the file already exactly matches (filename + size? Maybe we get a hash of some kind? It doesn't need to be a slow crypto hash, a "decent" hash like crc32 or xxHash is probably good enough)

  2. Is these a way to remove downloads of anything I've removed from the playlist?

Thanks!