search

clementine-player / Android-Remote

Control Clementine from your Android device
GNU General Public License v3.0
198 stars 80 forks source link

Application close and auto-disconnect #26

Closed amuttsch closed 10 years ago

amuttsch commented 10 years ago

From kittiho...@gmail.com on November 20, 2013 21:38:38

It would be nice if there was an easier/faster way to completely shut-down the application.

At the moment "android back" button kind of just minimizes the application. Normally "home" button does that and back closes the application. So the flow of this remote app goes a bit against the normal android UX.

If not through the back button, this could be solved using an extra button (possibly at the top of the application) which would disconnect AND shut down the application. At this moment, user first needs to disconnect and then close it which is a few unnecessary steps too mane in my opinion.

This would also reduce the battery consumption as well I guess since it is not necessary to have the remote turned on all the time (this is a remote application, not a player application and there is no need to keep it on as much as a player would be).

Original issue: http://code.google.com/p/clementine-remote-android/issues/detail?id=26

amuttsch commented 10 years ago

From asfa...@googlemail.com on November 21, 2013 05:17:14

It is intended that Clementine Remote behaves like a normal music player. Pressing back and reconnting every time the app closes would be very annoying each time you want to change the track. Lockscreen and bluetooth control wouldn't work either.

For a fast way to close the app I can include a new menu entry.

Labels: -Type-Defect Type-Enhancement

amuttsch commented 10 years ago

From asfa...@googlemail.com on November 21, 2013 07:29:05

This issue was closed by revision 3aad34d76bae .

Status: Fixed

amuttsch commented 10 years ago

From kittiho...@gmail.com on November 21, 2013 08:12:12

Thank you! :)

And I don't want to sound ungrateful, but how about adding it to the top, next to shuffle/repeat buttons? It might probably be used more frequently than the "love" button.

Or if there was an option under settings - a simple checkbox to include the application close button. Or to replace the "love" button with "close"? If you don't feel like doing that, I could do that for you and than send you the patch?

amuttsch commented 10 years ago

From asfa...@googlemail.com on November 22, 2013 02:39:42

The new version has a navigation drawer on the left hand side (like in the youtube or gmail app). I added the quit button there.

amuttsch commented 10 years ago

From kittiho...@gmail.com on November 22, 2013 02:41:51

Oh, ok. Awesome, thnx!