clementine-player / Android-Remote

Control Clementine from your Android device
GNU General Public License v3.0
198 stars 80 forks source link

Cannot add tracks from library to playlist #35

Closed szczad closed 10 years ago

szczad commented 10 years ago

Steps to reproduce:

  1. Open ClementineRemote
  2. Navigate to Library tab
  3. Long press on any entry and select "Add to current playlist" (or something like that)
  4. Clementine on PC shows nice dialog that it cannot open files (screenshot attached)

IMHO problem lays in path structure ie: path to the file is: file:///mnt/shared/Muzyka/Lossless/05. Gothic/A Perfect Circle/[2000] Mer de Noms/01 - The Hollow.flac but ClementineRemote tries to push command to add files: file:///mnt/shared/Muzyka/Lossless/05. Gothic/A Perfect Circle/%5B2000%5D Mer de Noms/01 - The Hollow.flac

zrzut ekranu z 2013-12-07 19 42 26

amuttsch commented 10 years ago

This one is already fixed, but you have to install a nightly build as this was fixed in Clementine and not in the remote (see here: https://code.google.com/p/clementine-player/issues/detail?id=4003)

You can get the latest nightly build from here: http://builds.clementine-player.org/

TamasBarta commented 10 years ago

Sorry for the dup, I didn't recognise my bug in this (though it's clear).

However, I downloaded the nightly built on Dec 5, and also builded Clementine from source (cloned the git repo from Google Code and used the master branch), and neither version could put my track on the playlist. Is it sure, that the fix for the issue on Google Code fixes this? Shall I continue there?

amuttsch commented 10 years ago

For me it works even with japanese characters, [ and other non latin characters...Can you send me the filename + path you want to add (From you computer, not the output from Clementine)?

TamasBarta commented 10 years ago

/mnt/hdd/Zenék/Goulasch Exotica/Betyárvizit (2008)/03 - Halak leszünk.mp3 is one good example. The popup says for that: file:///mnt/hdd/Zen%C3%A9k/Goulasch Exotica/Bety%C3%A1rvizit (2008)/03 - Halak lesz%C3%BCnk.mp3

amuttsch commented 10 years ago

Make sure you are using the latest version. I named a file like this and it worked like a charm. Maybe after you installed a new version, the old version was still started?

What does Help -> About tell you about the version? What OS do you use?

TamasBarta commented 10 years ago

Since then I restored to 1.2.1, but I double checked the about window, and it said the expected version numbers. Some 1.2.1~&@#@95blabla. Sorry, I can't remember precisely, but something 1.2.1~95-blabla was the version, so definitely not 1.2.1, which is downloadable from the website. It was identical with the version in the .deb filename from the http://builds.clementine-player.org/ubuntu-saucy/ site. Btw, I'm using Ubuntu 13.10 64 bit.

TamasBarta commented 10 years ago

Tried all the nightlies built since, and no luck. Can I provide any further information? Last tried with "1.2.1-106-ga43116b"

amuttsch commented 10 years ago

The popup still includes the %xx stuff instead of the actual character?

TamasBarta commented 10 years ago

It says exactly "Hiba file:///mnt/hdd/Zen%C3%A9k/30Y Diszkografia/30Y_Egy_perccel_tovabb_CD-HU-2004/02-ver_veritek.mp3 betöltésekor"

CattusNiger commented 10 years ago

I have exactly the same problem under Kubuntu 13.04 and with Clementine version 1.2.1-106-ga43116b. And as my music folder is "Música" I have this problem with all my songs.

amuttsch commented 10 years ago

Please open a terminal and post the output of "locale" and the language set in Clementine (Settings -> Behaviour -> Language)

CattusNiger commented 10 years ago

The output of locale is:

LANG=es_ES.UTF-8 LANGUAGE= LC_CTYPE="es_ES.UTF-8" LC_NUMERIC="es_ES.UTF-8" LC_TIME="es_ES.UTF-8" LC_COLLATE="es_ES.UTF-8" LC_MONETARY="es_ES.UTF-8" LC_MESSAGES="es_ES.UTF-8" LC_PAPER="es_ES.UTF-8" LC_NAME="es_ES.UTF-8" LC_ADDRESS="es_ES.UTF-8" LC_TELEPHONE="es_ES.UTF-8" LC_MEASUREMENT="es_ES.UTF-8" LC_IDENTIFICATION="es_ES.UTF-8" LC_ALL=

And the lenguage is set to default in Clementine.

Thanks.

bvlucena commented 10 years ago

i think i had the same problem. just removed the angled brackets [ ] and it worked.

amuttsch commented 10 years ago

Do you use Clementine 1.2.1 or 1.2.2?

bvlucena commented 10 years ago

1.2.1

On 3/7/14, Andreas notifications@github.com wrote:

Do you use Clementine 1.2.1 or 1.2.2?


Reply to this email directly or view it on GitHub: https://github.com/clementine-player/Android-Remote/issues/35#issuecomment-37054479

Bruno Lucena (81) 89333737 b bruno.lucena@upfe.brvlucena@gmail.com

amuttsch commented 10 years ago

I fixed this issue in 1.2.2. Please download it and try again.

CattusNiger commented 10 years ago

I have just downloaded the 1.2.2 version for my Kubuntu 13.10 64 bits and still the same:

Error al cargar file:///home/javi/M%C3%BAsica/El Noi del Sucre/(2013) A Mi Manera Vol. 2/09 - Vivan las cadenas, muera la inteligencia.mp3

If I have an accent mark, there is an error. And in spanish accents are quite common.

amuttsch commented 10 years ago

Hm, you are right. I was sure i fixed this :-(

amuttsch commented 10 years ago

Please try the new build: http://builds.clementine-player.org/android/ClementineRemote-release-v8.5-48-g511b82b.apk

Note: You have to uninstall the play store version first as this apk is signed differently.

CattusNiger commented 10 years ago

Perfect! Now it's working. I've tried with different files and works fine.

Could you inform me when this version is available in the Play Store so I could download it and forget about it?

Thanks a lot.

amuttsch commented 10 years ago

Hurray :-)

You can subscribe to this atom feed and you will be notified on a new release! https://github.com/clementine-player/Android-Remote/tags.atom

CattusNiger commented 10 years ago

Done! Thanks a lot for your efforts!