Crash when connecting to Clementine (on debug build)

[Kuitsi]

This happens in ClementineRemote-release-v8.5-77-ge053eeb.apk and in version built from git at e053eebd60da3a3a7691c4678d00875a27d6b21c.

Stacktrace:

java.lang.NullPointerException at de.qspool.clementineremote.ui.fragments.PlayerFragment.onCreateOptionsMenu(PlayerFragment.java:164) at android.support.v4.app.Watson.onCreatePanelMenu(Watson.java:55) at com.actionbarsherlock.ActionBarSherlock.callbackCreateOptionsMenu(ActionBarSherlock.java:560) at com.actionbarsherlock.internal.ActionBarSherlockNative.dispatchCreateOptionsMenu(ActionBarSherlockNative.java:64) at com.actionbarsherlock.app.SherlockFragmentActivity.onCreatePanelMenu(SherlockFragmentActivity.java:164) at com.android.internal.policy.impl.PhoneWindow.preparePanel(PhoneWindow.java:395) at com.android.internal.policy.impl.PhoneWindow.invalidatePanelMenu(PhoneWindow.java:760) at com.actionbarsherlock.internal.ActionBarSherlockNative.dispatchInvalidateOptionsMenu(ActionBarSherlockNative.java:51) at com.actionbarsherlock.app.SherlockFragmentActivity.invalidateOptionsMenu(SherlockFragmentActivity.java:149) at com.actionbarsherlock.app.SherlockFragmentActivity.supportInvalidateOptionsMenu(SherlockFragmentActivity.java:155) at android.support.v4.app.Fragment.setHasOptionsMenu(Fragment.java:803) at de.qspool.clementineremote.ui.fragments.PlayerFragment.onCreate(PlayerFragment.java:89) at android.support.v4.app.Fragment.performCreate(Fragment.java:1477) ...

[amuttsch]

I just wanted to reply to your mail :D

The crash occurs every time you connected to Clementine, right?

Please try this new build and report if the crash is gone, thanks! http://builds.clementine-player.org/android/ClementineRemote-release-v8.5-78-g3c8bc4d.apk

[Kuitsi]

Yes, it did crash every time. Your fix works. Tested it directly from git as I did not want to reinstall it again due to different signing keys ;)

[amuttsch]

Awesome, thanks for your feedback!