Comments' tooltip is ugly

[Clementine-Issue-Importer]

From andrew.gaydenko on December 01, 2010 17:42:19

Current trunk is in use. Long comments tooltip takes full screen width (1920 px) and doesn't respect \n char.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=1011

[Clementine-Issue-Importer]

From davidsansome on December 01, 2010 08:48:03

Labels: Milestone-0.6

[Clementine-Issue-Importer]

From davidsansome on December 04, 2010 08:43:11

This issue was closed by revision r2337 .

Status: Fixed

[Clementine-Issue-Importer]

From andrew.gaydenko on December 04, 2010 09:28:54

David, I have tried r2338 - still have a single tooltip string showing (literally) \n (or, simetimes, \r\n). Must a slash be slashed?

text.replace("\n", "
"); text.replace("\r\n", "
");

[Clementine-Issue-Importer]

From andrew.gaydenko on December 04, 2010 09:47:52

Sorry, the order must be reversed:

text.replace("\r\n", "
"); text.replace("\n", "
");

have tried - it does work.

[Clementine-Issue-Importer]

From davidsansome on December 04, 2010 10:07:07

Huh that's weird - are you sure the comment tag doesn't literally contain a slash character and an "n" character? Dump it with id3v2 commandline tool or look at it in the edit song information dialog.

[Clementine-Issue-Importer]

From andrew.gaydenko on December 04, 2010 10:22:46

At least I have plenty of such ones :-) And I have tried above two lines - the do work for me as expected.

For most albums in my lib I have used entagged (Java app) to fill in flac tags from freedb.org.

At any case above two lines can be first ones before single-slash replacement variant:

text.replace("\r\n", "
"); text.replace("\n", "
"); text.replace("\r\n", "
"); text.replace("\n", "
");

id3v2 shows nothing for flac:

$ id3v2 -l 1.flac 1.flac: No ID3 tag

[Clementine-Issue-Importer]

From andrew.gaydenko on December 04, 2010 10:24:18

Well, of course, editing dialog shows literally \n also.

[Clementine-Issue-Importer]

From davidsansome on December 04, 2010 15:46:55

Well then if the comment field actually contains \n then it's correct for Clementine to display \n...

[Clementine-Issue-Importer]

From andrew.gaydenko on December 04, 2010 16:00:34

I don't know the specification for comment, but at case (if the case takes place in accordance with spec) EOL simbol is replaced with literal \n, it is good thing to cure such invalid cases as far as oviously EOL must be displayed. Typical case - jazz combo musicians a listed and devided by \n. And it isn't rare case. I just don't know another ones :-)

[Clementine-Issue-Importer]

From andrew.gaydenko on December 05, 2010 05:34:21

David, I's sure literal \n is a standard de facto. I have digged in freedb.org - all albums I have found do use this way. For example: http://www.freedb.org/freedb/jazz/b811560d We see:

EXTD=July 14 & 21, 1956\nSt. Louis, MO\nPresided over by the legendary EXTD= Spider Burks

So, I'm absolutely sure now it is a common practice to keep comments' EOLs this (via literal \n or \r\n) way. May be it isn't a spec. But it is a reality ;-)

[Clementine-Issue-Importer]

From davidsansome on December 05, 2010 05:42:01

Ok fine :) try r2351 and let me know if it's better

[Clementine-Issue-Importer]

From andrew.gaydenko on December 05, 2010 05:58:42

Thanks! - it does work definitely excellent :-)

Attachment: clemTooltip01.png

[Clementine-Issue-Importer]

From andrew.gaydenko on December 14, 2010 15:17:47

David, I have found literal \t combination is also used for comments.