Open Clementine-Issue-Importer opened 10 years ago
From john.maguire on January 06, 2011 03:35:16
This comment in our code contradicts you: http://code.google.com/p/clementine-player/source/browse/trunk/src/core/mpris2.cpp?r=2576#150 Can you make sure this is now correct in the Ubuntu sound menu?
From conor%forwind.net@gtempaccount.com on January 06, 2011 04:07:18
There are a number of things here. The registration mechanism for the Ubuntu Sound menu has changed for Natty. No longer do you need libindicate. The comment in the code points to some confusion between the previous libindicate desktop file path and the DesktopEntry MPRIS property. These are two completely different things. In the Maverick release the MPRIS destkop prop was unused for registration, hence why the incorrect value went undetected.
For Natty, registration is done entirely using the MPRIS interface. You just need to make sure the desktopentry property adheres to the MPRIS spec (filename without the extension). The sound menu now also supports the new playlist extension and will automatically detect that it is available and populate the menu with the extra widgets (as of release 0.5.4).
Conor
From keirangtp on January 06, 2011 04:35:09
The one thing I'm sure is (double checked this right now) - returning "clementine" instead of the full desktop path breaks the sound menu in 10.10. Hence the code comment I added at some point.
Are you saying that we should handle the registration differently on 11.04 and pre 11.04 Ubuntus?
We plan to support the Playlist interface too.
From keirangtp on January 06, 2011 04:36:45
Or are you saying that we are doing the registration wrong hence the proper desktop value ("clementine") is not working?
From conor%forwind.net@gtempaccount.com on January 06, 2011 04:45:26
"clementine" instead of the full desktop path breaks the sound menu in 10.10. Hence the code >>comment I added at some point.
Odd, well I'm very certain that the DesktopEntry MPRIS property is not used for Maverick. However the Libindicate desktop path is used. This method must be trying to act for both. For Maverick if it works, great no need to do anymore work. Sorry I never introduced myself, I'm Conor Curran the Canonical developer working on the sound menu.
and pre 11.04 Ubuntus?
Yes, for 11.04 on the registration has changed entirely, basically got rid of libindicate as a dependency (therefore you should do the same) and uses the MPRIS interface(s) entirely.
Excellent, 0.5.4 for the sound menu will have playlist support built in (released today sometime)
From conor%forwind.net@gtempaccount.com on January 06, 2011 04:56:59
And the new details for registration can be found on the spec https://wiki.ubuntu.com/SoundMenu#Registration%20process
From keirangtp on January 06, 2011 06:08:20
I've rechecked the code and indeed, we're using the DesktopEntry() as the argument for indicate_server->setDesktopFile(). I'll clean this up.
Thanks for all the additional information!
Summary: new SoundMenu registration process in Natty
Status: Accepted
Labels: Milestone-0.7
From conor%forwind.net@gtempaccount.com on January 06, 2011 06:40:28
not a problem :)
From davidsansome on March 13, 2011 09:46:20
Labels: -Milestone-0.7
From conor%forwind.net@gtempaccount.com on January 05, 2011 19:34:53
Hi,
It looks like the desktopentry property on the root interface for mpris2 is set to the wrong value. It needs to only be 'clementine' and not the full path the desktop file. This needs to be working in order to make the player integrate properly with the ubuntu sound menu.
Thanks Conor (ronoc on irc)
Original issue: http://code.google.com/p/clementine-player/issues/detail?id=1245