clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.75k stars 676 forks source link

Wrong character in id3tag #1277

Closed Clementine-Issue-Importer closed 10 years ago

Clementine-Issue-Importer commented 10 years ago

From h.ibrahim.gungor on January 11, 2011 19:48:21

What steps will reproduce the problem? 1. Fire up Clementine 0.6, open a song containing Turkish characters (i.e.: ö,ç,ğ,ü,ş,ı)

  1. Observe that Artist/Song/Album informations misses Turkish characters in some mp3 files. I've added the midentify output (mplayer identify) of two mp3 files.
  2. Clementine plays fine whether the id3 infos are wrong or not, but special characters are missing. What is the expected output? What do you see instead? I want to see the actual ID3 tags like i see in Amarok, Rhytmbox etc. What version of the product are you using? On what operating system? 0.6. Pardus GNU/Linux

I'm the maintainer of Clementine for Pardus Linux. These are the options i've enabled:

cmake -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_C_FLAGS="-mtune=generic -march=x86-64 -O2 -pipe -fomit-frame-pointer -fstack-protector -D_FORTIFY_SOURCE=2" -DCMAKE_CXX_FLAGS="-mtune=generic -march=x86-64 -O2 -pipe -fomit-frame-pointer -fstack-protector -D_FORTIFY_SOURCE=2" -DCMAKE_LD_FLAGS="-Wl,-O1 -Wl,-z,relro -Wl,--hash-style=gnu -Wl,--as-needed -Wl,--sort-common" -DCMAKE_BUILD_TYPE=RelWithDebInfo -DHAVE_LIBNOTIFY=ON -DENGINE_GSTREAMER_ENABLED=ON -DENGINE_QT_PHONON_ENABLED=OFF -DENGINE_LIBVLC_ENABLED=OFF -DENGINE_LIBXINE_ENABLED=OFF -DUSE_SYSTEM_QXT=ON -DUSE_SYSTEM_QTSINGLEAPPLICATION=OFF -DSTATIC_SQLITE=OFF -DUSE_SYSTEM_PROJECTM=ON -DENABLE_WIIMOTEDEV=ON -DENABLE_LIBGPOD=ON -DENABLE_IMOBILEDEVICE=ON -DENABLE_LIBMTP=ON -DENABLE_GIO=ON -DENABLE_VISUALISATIONS=ON -DBUNDLE_PROJECTM_PRESETS=OFF . Please provide any additional information below. Other music players (Amarok and Rhythymbox) show the informations provided by ID3tag without a loss of special character. There are two songs of a great artist named "Bülent Ortaçgil".

There is no problem of the Artist IDtag for the second song "Deniz Kokusu. Clementine shows like it should be: Bülent Ortaçgil.

But the first song "Sensiz Olmaz", the Artist IDtag that Clementine shows is "B?lent Orta?gil". "ü" and "ç" Turkish-specific characters are not shown.

The outputs of these files:

[Bülent Ortaçgil] > midentify "Bu Şarkılar Adam Olmaz/bülentortaçgil-Sensiz Olmaz.mp3" ID_AUDIO_ID=0 ID_CLIP_INFO_NAME0=Title ID_CLIP_INFO_VALUE0=Sensiz\ Olmaz ID_CLIP_INFO_NAME1=Artist ID_CLIP_INFO_VALUE1=B�lent\ Orta�gil ID_CLIP_INFO_NAME2=Album ID_CLIP_INFO_VALUE2= ID_CLIP_INFO_NAME3=Year ID_CLIP_INFO_VALUE3=-1 ID_CLIP_INFO_NAME4=Comment ID_CLIP_INFO_VALUE4= ID_CLIP_INFO_NAME5=Genre ID_CLIP_INFO_VALUE5=Other ID_CLIP_INFO_N=6 ID_FILENAME=Bu\ Şarkılar\ Adam\ Olmaz/bülentortaçgil-Sensiz\ Olmaz.mp3

[Bülent Ortaçgil] > midentify "Eski Defterler/Bülent Ortaçgil-03-Deniz Kokusu.mp3" ID_AUDIO_ID=0 ID_CLIP_INFO_NAME0=Title ID_CLIP_INFO_VALUE0=Deniz\ Kokusu ID_CLIP_INFO_NAME1=Artist ID_CLIP_INFO_VALUE1=B�lent\ Orta�gil ID_CLIP_INFO_NAME2=Album ID_CLIP_INFO_VALUE2=Eski\ Defterler ID_CLIP_INFO_NAME3=Year ID_CLIP_INFO_VALUE3=1999 ID_CLIP_INFO_NAME4=Comment ID_CLIP_INFO_VALUE4= ID_CLIP_INFO_NAME5=Track ID_CLIP_INFO_VALUE5=3 ID_CLIP_INFO_NAME6=Genre ID_CLIP_INFO_VALUE6=Unknown ID_CLIP_INFO_N=7 ID_FILENAME=Eski\ Defterler/Bülent\ Ortaçgil-03-Deniz\ Kokusu.mp3

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=1277

Clementine-Issue-Importer commented 10 years ago

From john.maguire on January 12, 2011 04:55:15

Please attach an example file.

Clementine-Issue-Importer commented 10 years ago

From h.ibrahim.gungor on January 12, 2011 10:36:15

Well, here is the mp3 song i mentioned above. And a screenshot of how it looks like.

Attachment: clementine-wrong-char.png bülentortaçgil-Sensiz Olmaz.mp3

Clementine-Issue-Importer commented 10 years ago

From Taras.Puchko on January 26, 2011 12:23:04

It looks like Clementine 0.6 prefers ID3v1.1 to ID3v2.4.0

Clementine-Issue-Importer commented 10 years ago

From h.ibrahim.gungor on March 20, 2011 14:16:11

This issue is fixed somewhere between r2629 .. r2988 . It means 0.7 RC1 contains this fix. I'd like to bisect it where the issue fixed if i had the time. Thanks :)

Clementine-Issue-Importer commented 10 years ago

From davidsansome on March 20, 2011 14:21:30

It was probably r2931 . Let me know if I'm right and I'll close the issue :)

Clementine-Issue-Importer commented 10 years ago

From h.ibrahim.gungor on March 20, 2011 15:55:50

Yeap, this commit is the fix. I'm following the commits once in a week but i missed this one i guess. You can close the issue. Thanks :)

Clementine-Issue-Importer commented 10 years ago

From davidsansome on March 20, 2011 15:58:15

Woohoo!

Status: Fixed