search

clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.72k stars 671 forks source link

scrobbling queue lost when offline and restarting the application #174

Closed Clementine-Issue-Importer closed 10 years ago

Clementine-Issue-Importer commented 10 years ago

From kadaimx on April 06, 2010 08:21:09

What steps will reproduce the problem? 1. Load Clementine and disconnect yourself from the network (we want to generate a queue of pending submissions)

  1. Play then some files (2 or 3) and make sure they were attempted to be sent to last.fm service.
  2. Shutdown Clementine, connect yourself to the network. Once connected, start again the software.
  3. Look then your last.fm account for the played tracks. They will not be there, meaning that they got lost on shutdown. What is the expected output? What do you see instead? Expected Clementine to -save- on a queue (similar to Amarok 1.4) the pending tracks to be sent to last.fm service. What version of the product are you using? On what operating system? Revision 585 on Kubuntu 9.10 Please provide any additional information below. While this is not a critical issue, it can be considered important for any of the users that like to have stats of all his/her played tracks.

Now, I'm not sure who handles then the queue, but apparently Clementine had to do that, no?

In such case, there will be the need to create a file with the information pending to be sent just to do not loss it.

Additional to it, as fine-tunning, the user could be then informed about if a track was successfully submitted to last.fm or not on the status bar of the main window (for example, saying "Track successfully sent to

" or either "Scrobble of failed. tracks on queue") _Original issue: http://code.google.com/p/clementine-player/issues/detail?id=174_
Clementine-Issue-Importer commented 10 years ago

From john.maguire on April 14, 2010 08:05:13

Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low Component-Radio

Clementine-Issue-Importer commented 10 years ago

From keirangtp on January 11, 2011 00:32:58

Summary: scrobbling queue lost when offline and restarting the application

Clementine-Issue-Importer commented 10 years ago

From keirangtp on January 11, 2011 00:33:23

Issue 1275 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From matei.traistaru on January 11, 2011 01:00:11

Thanks for merging.... Anyway it happened again last night. I mean I tried all possibile scenarios: disconnecting while Clementine was playing, playing a whole playlist while offline,etc. Only this time I got mixed results: 2-3 songs were scrobbled, but that's just too few from a more than 50 involved in this 'test'.

Clementine-Issue-Importer commented 10 years ago

From dasilva.raq on January 30, 2011 10:40:27

Same here...with Foobar or even last.gm app, they scrobble offline the tracks you listen (sending them when a person is back online). This would be super, I think it is really important. Thanks mates, Clementine is my favourite player all time

Clementine-Issue-Importer commented 10 years ago

From bru.fer on January 30, 2011 10:55:02

Please add that feature...please please! I use Clementine on Mac (but I think it is a general issue). It won't scrobble to last.fm tracks listened offline. Thanks, Clementine is super great!

Clementine-Issue-Importer commented 10 years ago

From goetzchrist on January 30, 2011 11:39:27

Some days ago Last.fm had some problems with the servers, and where unreachable for many people.[1] Last.fm expects that if the user has no Internet connection, the client (music player) will cache the scrobbled songs, to summit them when the connection is back again.[1]

from Last.fm: "Some of you are worried about the status of your scrobbles; all scrobbles that are making it through are safe, and client caching should ensure that any that aren’t are queued and will be submitted correctly once the service is fully restored."

Caching the scrobbled songs is not only useful when Last.fm is down, but also useful when the user has not Internet connection available.

[1] http://blog.last.fm/2011/01/21/about-the-last-24-hours

Clementine-Issue-Importer commented 10 years ago

From bru.fer on January 30, 2011 18:46:43

We are talking about other thing! We referring to scrobble and submit tracks listened while you were offline once you're back online.

Clementine-Issue-Importer commented 10 years ago

From goetzchrist on January 30, 2011 20:21:53

That's the same thing. The cause is different, but the consequence is the same.

Clementine-Issue-Importer commented 10 years ago

From bru.fer on January 31, 2011 05:03:34

Yeah...You're right! This is really important for the users who like the scrobbling services. I don't use last.fm to listen to music (streaming or radios). I use it to make the stats of what i listen, and it's really important that the listened tracks offline remain in a cache to be sent when there is a network connection available! Cheers for best player around

Clementine-Issue-Importer commented 10 years ago

From quezak on April 10, 2011 12:34:16

I don't know whether my casee fits here or is another issue. When for some reasons (e.g. clogged upload or wifi being down for some seconds) Clementine doesn't manage to scrobble a file, it seems to stop scrobbling at all! It starts again only if I restart it or logout an fill in again last.fm settings, unfortunately either way all that I have listened before is lost... It's quite annoying when after a week of uptime I realize that scrobbling stopped after the first day :/ I think Clementine should somewhat check if the scrobble info was sent, and if not - store the queue no matter what...

Clementine-Issue-Importer commented 10 years ago

From quezak on April 10, 2011 12:44:59

I thought about another idea. When scrobbling fails, in last.fm settings tab there could be a button "try to send the queue now". It would be useful in case Clementine doesn't realize it can scrobble now, and the user wants to shut it down without losing scrobbles.

Clementine-Issue-Importer commented 10 years ago

From patstew on April 25, 2011 14:18:26

Today I noticed Clementine didn't scrobble after the network disconnected, even after reconnection. However it did scrobble all the songs it missed after I restarted clementine, so it seems this bug report has been fixed?

Clementine-Issue-Importer commented 10 years ago

From adecorte on April 28, 2011 03:52:16

I fixed a couple of problems with offline scrobbling in r3197 , but Clementine already tries to send the queued songs after restarting. If some songs got lost it is due to last.fm servers, we can't really do much

Clementine-Issue-Importer commented 10 years ago

From keirangtp on April 28, 2011 13:54:44

So can we close this one?

Clementine-Issue-Importer commented 10 years ago

From quezak on April 28, 2011 14:02:32

Is there a way to check what/when was Clementine trying to submit to last.fm, and/or what is still waiting for submission? My scrobbles were lost again: on 26 IV I were listening all day and night, today got home, and nothing is scrobbled between 25 IV and today: http://www.lastfm.pl/user/Quezak/tracks

Clementine-Issue-Importer commented 10 years ago

From adecorte on April 28, 2011 23:59:48

If you look at the command prompt you should see last.fm activity and some output when scrobbles are sent. There's no output about the submission cache though, I'll add a counter so you can check if the problem is either tracks not added to the cache or tracks not sent to the server @keirangtp: some tracks lost is ok, every track lost is not, let's see if we can sort out this last case before closing

Clementine-Issue-Importer commented 10 years ago

From adecorte on April 30, 2011 01:40:42

Can you try to start the last revision ( r3223 ) from the console? you should get in the output a message "There are X tracks in the last.fm cache.". Try to play some songs while offline and tell me if that number is different from zero. If it isn't so, there is a problem ;-)

Clementine-Issue-Importer commented 10 years ago

From quezak on May 01, 2011 15:15:54

Ok, I tested it a little bit, and everything seems to work well. Tracks offline are counted in the cache, and then clearly submitted on reconnection or app restart. Only two things that I noticed:

anyway, everything seems to work. In two weeks I'll be going out for some days again, so I'll have time to investigate this on long distance run without cutting myself from the net now. I think the issue can be closed for now, and I'll ask for re-opening if anything goes wrong.

Clementine-Issue-Importer commented 10 years ago

From adecorte on May 02, 2011 00:33:09

Thanks for your help, you're right, ScrobbleCache requires at least liblastfm>= 0.3.1; since this version was released nearly a year ago, maybe you could ask for an update in Gentoo ;-) I'll remove that code anyway so you can compile again with 0.3.0, even if probably 0.3.3 is a better choice. As for that timeout, it's an internal choice of liblastfm, we can't do much. The counter anyway is reset if the connection becomes available again

Status: Fixed

Clementine-Issue-Importer commented 10 years ago

From matei.traistaru on May 02, 2011 01:35:55

It works well now. Thank you all.

BrianZbr commented 8 years ago

Clementine is only scrobbling when I am online. Nothing I listen to while offline is scrobbled, even if Clementine has not been restarted. Is there anything in the above I should try?

EDIT: It started working eventually.