clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.72k stars 671 forks source link

Shout/Icecast: artist and title are swapped #2017

Closed Clementine-Issue-Importer closed 10 years ago

Clementine-Issue-Importer commented 10 years ago

From moe9001 on June 25, 2011 15:47:45

What steps will reproduce the problem? 1. Add your favorit shoutcast/icecast streaming server to the playlist. I am using this one: http://stream2.tormentedradio.com:8070 2. Start playing and see what will happen to artist and title strings What version of the product are you using? On what operating system? Ubuntu 11.04, clementine trunk, revision 3430 In the source code (core/player.cpp, Player::EngineMetadataReceived()) I already found a hack for that issue for SomaFM and icecast servers. For somaFM it checks for the according TLD, for icecast servers it checks the fragment part of the URL to identify icecast servers: it needs to be "icecast". If one of these conditions is true, title and artist are swapped in the metadata.

As soon as a string "#icecast" is appended to the URL of my internet radio station everything is fine for artist/title, as they are swapped again.

There should be another, more reliable way for icecast detection. I doubt that most shoutcast/icecast server URLs contain the required fragment part.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=2017

Clementine-Issue-Importer commented 10 years ago

From moe9001 on June 25, 2011 06:52:22

There is already a discussion about this issue. See issue 1035 : http://code.google.com/p/clementine-player/issues/detail?id=1035 So this issue here can be closed. Sorry.

Clementine-Issue-Importer commented 10 years ago

From davidsansome on June 25, 2011 06:57:29

Status: Duplicate
Mergedinto: 1035