Patches from OpenBSD WIP port

[Clementine-Issue-Importer]

From persgray@gmail.com on October 05, 2011 21:20:17

Hello all.

Here are patches that were used to port Clementine to OpenBSD. They are about three things:

1. Forcing -ldl dependency: OpenBSD doesn't use/have it;
2. Not including X11 headers directories to compiler search path;
3. Wrong header ( instead of ) for isnan(3) in C++: platforms may include within , but this is not something that could be relied upon.

[2] patches are safe, IMO, while [1] and [3] definitely needs testing on other platforms ([3] theoretically may fail with some broken standard C++ library).

Attachment: patch-src_CMakeLists_txt patch-3rdparty_qxt_CMakeLists_txt patch-3rdparty_libprojectm_Renderer_CMakeLists_txt patch-3rdparty_libprojectm_Renderer_BeatDetect_cpp patch-3rdparty_libprojectm_Common_hpp patch-3rdparty_libprojectm_CMakeLists_txt

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=2277

[Clementine-Issue-Importer]

From persgray@gmail.com on October 05, 2011 12:25:18

Sorry, forgot to describe "3rdparty/libprojectm/Renderer/BeatDetect.cpp": it just unbreaks compilation.

[Clementine-Issue-Importer]

From arnaud.bienner on October 05, 2011 13:48:03

Interesting :) Your modifications are related to Projectm (which is included, patched, in Clementine, but not developed by us): maybe you should try to contact them directly?

[Clementine-Issue-Importer]

From persgray@gmail.com on October 05, 2011 13:55:00

Yes, I thought about this, but I'll have to port Projectm separately then, and I don't know how much time will this take. If you don't like patches to Projectm, nevermind.

[Clementine-Issue-Importer]

From arnaud.bienner on November 02, 2011 08:10:30

Labels: PatchAttached

[Clementine-Issue-Importer]

From davidsansome on November 29, 2011 03:29:16

This issue was closed by revision c084d13ff11d .

Status: Fixed