clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.75k stars 676 forks source link

Unable to pause or seek Spotify tracks #2503

Open Clementine-Issue-Importer opened 10 years ago

Clementine-Issue-Importer commented 10 years ago

From whalens...@gmail.com on December 21, 2011 23:43:02

What steps will reproduce the problem? 1. Create a Spotify account (if you don't have one already)

  1. Configure Spotify in Clementine
  2. Play a Spotify track What is the expected output? What do you see instead? One should be able to seek or pause a Spotify track, instead these features are not usable. What version of the product are you using? On what operating system? Clementine 0.7.3-536-gb5f906a Kubuntu 11.10 Please provide any additional information below. I wasn’t sure weather to report this as a defect or feature request. As pausing and seeking are basic and rather expected functions, I decided to report is as a defect. It could be that this is caused by a limitation of Spotify Core, or the way the stream is processed by Clementine.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=2503

Clementine-Issue-Importer commented 10 years ago

From davidsansome on December 27, 2011 07:53:49

Issue 2457 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From adamplus...@gmail.com on December 27, 2011 16:00:08

This is still a problem in 1.0

Clementine-Issue-Importer commented 10 years ago

From whalens...@gmail.com on December 27, 2011 18:28:48

Interestingly, pausing is available when one selects a Spotify song by searching for it (using universal or Spotify specific search). Seeking remains unusable, however.

Clementine-Issue-Importer commented 10 years ago

From whalens...@gmail.com on December 29, 2011 15:08:45

Correction - The pausing problem still exists. I was mistakenly playing search results. I have deleted my previous comment.

Clementine-Issue-Importer commented 10 years ago

From whalens...@gmail.com on January 27, 2012 12:50:47

Bump The pausing issue at least seems to be a simple issue of enabling the button when a Spotify track is played directly, at playing a Spotify track by searching for it enables the button. I'd submit a patch myself, but C++ is not my language of choice. Could someone please fix these very annoying bugs?

Clementine-Issue-Importer commented 10 years ago

From john.maguire on February 02, 2012 03:12:36

Issue 2687 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From tommiepo...@gmail.com on March 15, 2012 02:19:16

Any update on the issue?

Clementine-Issue-Importer commented 10 years ago

From adamplus...@gmail.com on March 25, 2012 12:52:24

Still not fixed in ClementineSetup-1.0.1-328

Clementine-Issue-Importer commented 10 years ago

From steffeno...@gmail.com on October 18, 2012 13:38:42

Sitting on 1.1 rc1, still not fixed. This seems like quite a wierd problem to me, so im gonna have a stab at it...

Clementine-Issue-Importer commented 10 years ago

From russomar...@gmail.com on February 25, 2013 08:25:12

I have the same problem. When I play a track from my Spotify playlists or from Spotify specific search results I can't pause it, and if I try to select a specific position on the track, nothing happens and Clementine keeps playing it. Both the pause button and the position indicator are grey and disabled. However, pause works fine for the Spotify tracks selected from universal search results. Clementine 1.1.1 on Windows XP

Clementine-Issue-Importer commented 10 years ago

From pie.or.paj on March 31, 2013 05:58:52

Took a look at the source and saw that pausing is simply disabled. I don't know why because if I enable it it works good.

I'm attaching a patch to enable pausing. Hopefully a developer will apply it or explain why it's disabled.

Attachment: enable spotify pause.patch

Clementine-Issue-Importer commented 10 years ago

From whalens...@gmail.com on March 31, 2013 06:26:18

Was seeking also patched?

Clementine-Issue-Importer commented 10 years ago

From pie.or.paj on March 31, 2013 08:07:46

No, I hadn't time to investigate that. Will see if I can enable that later. It may be just to remove the disable but it may also be more work.

Clementine-Issue-Importer commented 10 years ago

From pie.or.paj on March 31, 2013 12:57:41

I have looked into seeking Spotify now and there is a good bit missing. After I have done some hacking I succeeded to forward the seeking request to libspotify but after the seek it's is stuck in buffering.

I'm giving up now. I feel that I need more experience with libspotify to fix this. Also a better knowledge of Clementines source code, now I have to look around and search pretty much.

Clementine-Issue-Importer commented 10 years ago

From pie.or.paj on April 04, 2013 07:25:24

I did talk to hatstand at IRC and he pointed out that just removing the disable means that libspotify rill continue to fill the buffer when paused. I did some looking and testing and have now produced a new patch that tells libspotify that we have paused. Unfortunately it adds some Spotify specific in GstEnginePipeline. But that file already contained some Spotify specific code, and by looking how other things (album art) are handled right now it's how it's done.

There are duplications in GstEnginePipeline. I don't know how I should handle that but I guess some developer of Clementine does so I left it there and whoever looks at this patch could fix it pretty easily before applying.

Anyway, with this pausing in Spotify works without flooding the buffer.

Attachment: spotify_pause.patch

Clementine-Issue-Importer commented 10 years ago

From dtg...@gmail.com on May 06, 2013 10:34:49

Would definitely like to see this. I double checked and the patch from pie.or.paj hasn't been incorporated into the HEAD branch. Is there any intention to actually get this in?

partofthething commented 10 years ago

The patch is now a 404. Can we get a repost?

ArnaudBienner commented 10 years ago

Second patch applied: commit cbc6e5cf4dc59782cb94a96ee008766c67bb8492

gfauredumont commented 9 years ago

Hey Arnaud,

Good to see you're still working on this: it's became my primary player now ;)

I have a little bug though: I can't pause or seek on Spotify tracks... but I'm probably not using the right plugin: could you tell me where I can get the latest version please ?

Keep up ! (And hope to see you if you come to Paris !)

ArnaudBienner commented 9 years ago

Hey Guillaume!

Glad to hear Clementine became your main player :)

I've fixed the pause issue, but we haven't released a new Clementine version since. If you're really missing this, you can try one of the developer builds: builds.clementine-player.org which are built every commit. They are quite stable though. But if can live without this, better to wait for the next release.

Regarding the seek issue, it is not fixed (I tried to fix it, but this was too hacky so it was reverted). I should definitely have another look at it one day...

No plan to go to Paris ATM, but I will keep you posted ;)

ArnaudBienner commented 9 years ago

Reopening the issue as the seek issue isn't fixed (my commit 160b151652c47ffcec53ea22720bb2517e502799 was reverted in 88a63005096a3598701fcda1bbc7b926144895be, need to find a better solution. Should be possible to do something less hacky now we migrated to gstreamer 1.0 and flushing buffers should work).

Weegee commented 8 years ago

Any chance that seeking support for Spotify will make it in the 1.3 release? I think this might be a major dealbreaker for people who want to use Spotify within Clementine.

psyoma commented 8 years ago

Any update to to the seeking issue in Spotify? I'm using Version 1.3.1 and can't seek forward or back.

diegombeltran commented 7 years ago

Same here. Can't seek

jstevenr commented 7 years ago

Is this ever going to be fixed? It's a pretty glaring issue.

hatstand commented 7 years ago

Given the spotify API we use is deprecated, I doubt it.

rriemann commented 6 years ago

So can this be closed then as Can't Fix/WontFix?