search

clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.74k stars 675 forks source link

Skipping backwards through playlist via quick 'previous' succession #2833

Open Clementine-Issue-Importer opened 10 years ago

Clementine-Issue-Importer commented 10 years ago

From graham.c...@gmail.com on March 27, 2012 14:13:12

In many players, if you hit the 'previous' button/key in succession it will move backwards through the playlist. In Clementine it can't detect this and just restarts the current song.

This in on Mac, so possibly it is a Mac bug, I'm not sure.

Ideally Clementine would have some logic such as...

IF 'previous selected' AND 'within 2 seconds of start of current song in playlist' THEN Move backwards one step in playlist

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=2833

Clementine-Issue-Importer commented 10 years ago

From cecilko...@gmail.com on June 14, 2013 13:28:58

Confirming the issue occurs on Windows as well. Version 1.1.1 at the time of testing. I suspect this should be a defect, not an enhancement. I can reproduce the issue only when enabling "Dynamic mode" by selecting the "Dynamic random mix" smart playlist.

All other smart playlists and normal playlists seem to work as expected. Pressing the previous track button or the associated hotkey will correctly return to the beginning of the previously played track.

In dynamic mode however, the previous button will never return to the previously played track, and will continuously return to the beginning of the current track instead. Issue #2833 (fixed) sounds like it would've addressed the same problem, but that doesn't appear to be the case here. This seems to be specific to Dynamic mode.

Clementine-Issue-Importer commented 10 years ago

From cecilko...@gmail.com on June 14, 2013 13:31:22

Sorry, issue #2897 (fixed) was the related issue I was referring to.

Clementine-Issue-Importer commented 10 years ago

From barago...@gmail.com on June 26, 2013 02:02:56

It seems that Playlist::set_current_row is called twice when pressing the previous button. In dynamic mode it switches current and previous tracks twice so nothing happens. This patch should fix the button not working but it is still not possible to go back more than one track.

Attachment: 0001-Fixes-previous-track-button-not-working-in-dynamic-m.patch

Clementine-Issue-Importer commented 10 years ago

From davidsansome on August 04, 2013 00:33:32

Issue 3797 has been merged into this issue.