clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.76k stars 677 forks source link

Transcoding: Allow adding files to transcode from the playlist #3081

Open Clementine-Issue-Importer opened 10 years ago

Clementine-Issue-Importer commented 10 years ago

From mghansen256 on July 29, 2012 22:01:11

When using the "Tools->Transcode Music" dialog box, files can only be added to the list using the "Add..." button.

It would be nice to have a button "Add current playlist", "Add selected songs from current playlist", as well as having the possibility to drag files from the playlist into the file list in the dialog (since the dialog is non-modal already).

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=3080

v-fox commented 5 years ago

Is there any progress on this ? There are only 2 reasons to use transcode: creating simplified copies for mobile devices and ripping lossless originals. With good modern mobile DACs and ≥250GB SD cards this is more important then ever. My "favourites" playlist contains ~1300 entries and I'm not even much of an audiophile. But I would like to keep a copy on my phone's 64GB SD card just to have an option to use it as a HiFi source. People who actually listen music via phone daily would be dependant on that completely. But that playlist is heavily cherry-picked in a span of years, putting those tracks into transcoding dialogue by hand is an impossible task !

If you would do that, please, add options to either dump tracks in single playlist folder with ${playlist_order} - ${atrist} - ${year} - ${album} - ${track} naming (without "FAT-safe" character/size filtering but with auto-substitution to "unknown"/file-name on empty tags) or create subfolders for ${atrist}/${year} - ${album} + re-generated playlist with relatives paths for further transfer via USB.

Another essential function is to auto-skip transcoding for files of lower-than-target bitrate while still copying and renaming them. May have option to skip transcode on format difference to avoid re-encoding low-bitrate mp3 and aac, for example.

Furthermore, AAC encoding seems to be quite broken: https://github.com/clementine-player/Clementine/issues/5473 states that tags are lost and quality seem to be hard-coded to 128kb LC profile. That is a shame since if anything would have mobile hardware decoding support and good quality/compression ratio, it's AAC.

logological commented 4 years ago

The functionality to add songs from the playlist to the Transcode dialog is already in Clementine; it just doesn't work the way some people think it should. What you need to do is first select the songs in the playlist that you want to transcode (or press Ctrl+A if you want to select all the songs in the playlist), then either press Ctrl+Shift+T or right-click and select "Add file(s) to transcoder" from the context menu.

I think this issue should be kept open because I think the submitter's idea of having "Add current playlist" and/or "Add selected songs from current playlist" buttons in the Transcoder dialog itself is good. But I thought I would nonetheless draw attention to the existing mechanism for transcoding songs from the playlist, as it may not be obvious to everyone.