Organiser is not honoring forced-off Various Artists

[Clementine-Issue-Importer]

From kelle...@gmail.com on July 31, 2012 07:35:11

What steps will reproduce the problem? 1. Import tracks that are classified as "Various Artists"

2. Right click the tracks in the Library, and "Don't show in Various Artists"
3. Use Organize's %albumartist variable What is the expected output? What do you see instead? The organize dialog shows the album artist tag as expected. However, when files are converted, %albumartist is translated to "Various Artists" anyways The Organizer should honor if Various Artists has been forced off What version of the product are you using? On what operating system? 1.0.1-570-g06f7acd on Ubuntu 12.04 x64 Please provide any additional information below. Pretty sure the offending if statement is in src/core/organiseformat.cpp, line 149. Although I'm not much of a programmer, I changed it to this as a hack fix:

value = song.is_compilation() ? song.effective_albumartist() : song.effective_albumartist();

The Organiser now always uses the tags, and works for my purposes.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=3085

[Clementine-Issue-Importer]

From davidsansome on August 01, 2012 13:06:58

This is happening because Organise re-reads the tags for each song instead of using the data that's stored in the library. The tags it reads from disk don't contain the "Show/Don't show in Various Artists" flag (that's only in the library), which is why this is_compilation() check is returning the wrong thing.