clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.72k stars 671 forks source link

"Keep running in the backgroud" option #3557

Closed Clementine-Issue-Importer closed 10 years ago

Clementine-Issue-Importer commented 10 years ago

From pozdnyak...@gmail.com on March 16, 2013 13:03:39

Please, make "Keep running in the backgroud when the window is closed" independent from "Show tray icon" option. It's will be nice to have Clementine's controls in sound indicator without tray icon on Ubuntu with Unity.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=3557

Clementine-Issue-Importer commented 10 years ago

From fuuze...@fuuzetsu.co.uk on March 16, 2013 05:25:53

Send Clementine to a workspace that you don't use.

The effort required to implement it and the potential confusion this can cause are simply not worth it.

Clementine-Issue-Importer commented 10 years ago

From arnaud.bienner on March 16, 2013 07:49:42

We do this because of users who don't have a "Sound control" menu: in that case, if you enable "Keep running in the background" without "Show tray icon", Clementine will continue to run and no will have no way to access it anymore, except starting it again (this will actually pop the old instance), which is not user-friendly.

Status: Feature

Clementine-Issue-Importer commented 10 years ago

From arnaud.bienner on May 23, 2013 09:39:37

Issue 3701 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From robert.r...@gmail.com on May 24, 2013 02:52:41

I have a different point of view. The option "tray icon" is selected per default. If you change it, you normally know what you do and more important how to change it again. The same is true for the "keep running" option. This is actually nice, so you don't get an overload of icons if you are working.

So a normal user won't change it and other users know what they do. There are actually projects who consider (shaddow mode) is a good thing to have -- Easystroke/Empathy/... If you must you allways can make a "are u sure" pop-up for this problem.

Clementine-Issue-Importer commented 10 years ago

From arnaud.bienner on June 06, 2013 00:48:34

Issue 3723 has been merged into this issue.

MrMino commented 8 years ago

"The effort required to implement it and the potential confusion this can cause are simply not worth it."

  1. The effort required is to simply detach state of one checkbox from the other
  2. Second workspace means additional mess for people who work on gnome3
  3. If you are afraid that people will use it in 'confused' manner, then just add a warning to it.
  4. There aren't that many people who use the tray icon anyway
  5. On gnome it is SUPER annoying, especially if you are using topicons extension

The actual effort to accomplish this was erasing two lines from Clementine/src/ui/behavioursettingspage.h, namely 267 and 268:

  ui_->b_keep_running_->setEnabled(on);
  ui_->b_keep_running_->setChecked(on);
mattthw commented 7 years ago

@MrMino can you add a separate UI checkbox for this option and make a pull request? That is how I had changes I wanted get added. If you code it and it looks fine they will add it, especially if it is low lines of code that they can look at in < 5 mins. :)

MrMino commented 7 years ago

@mmccoy37 I doubt I will have time to do it, since I'm not a C++ developer and I don't have much experience with QT either. Also, I already switched to cmus, since I'm going lightweight, so...

Sorry, but I can't.