justen
commented
10 years ago I think the problem is in the StartPlaybackLater method of SpotifyServer. When a track ends and Clementine moves on to the next, if I'm following this right, this is the code invoked:
void SpotifyServer::StartPlaybackLater(const QString& uri, quint16 port) {
QTimer* timer = new QTimer(this);
connect(timer, SIGNAL(timeout()), timer, SLOT(deleteLater()));
timer->start(100); // lol
NewClosure(timer, SIGNAL(timeout()),
this, SLOT(StartPlayback(QString,quint16)),
uri, port);
}But if you just use the skip button to change tracks, this is used instead:-
void SpotifyServer::StartPlayback(const QString& uri, quint16 port) {
pb::spotify::Message message;
pb::spotify::PlaybackRequest* req = message.mutable_playback_request();
req->set_track_uri(DataCommaSizeFromQString(uri));
req->set_media_port(port);
SendOrQueueMessage(message);
}Skipping tracks manually works - and I think it's the creation of the QTimer in the first function that's causing the problem. Either the timer can't be created - according to the warnings because we're in the wrong thread - or it can't be started because we're not in a thread started with QThread. Whichever, the timer never starts so it can never kick StartPlayback. I'm not sure what the point is of the arbitrary 100ms countdown. Could it be removed completely? Or maybe just create a new QThread for the timer to count down in?
cpieloth
cincodenada
cschreib
urinieto
When playing a playlist which contains both local and Spotify tracks, Clementine sometimes gets stuck buffering forever at track transitions. Clicking the next track button in the interface gets things working again. When this happens, the following appears in the console:
I haven't been able to reproduce this with a very small playlist (i.e., one track local, one track from Spotify), but it happens pretty often on larger playlists.