search

clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.72k stars 671 forks source link

[REQUEST] Shortcut: delete from disk #4517

Open vokracko opened 10 years ago

vokracko commented 10 years ago

Title says it all. Thanks

Tatsh commented 10 years ago

File managers are for that. Clementine is not one.

vokracko commented 10 years ago

Maybe it is mine bad workflow, but I'm used to add all new music to my playlist and delete songs I don't like while they are playing. This could save some time (maximize player, ctrl+j, right click, delete from disk).

raphatbho commented 9 years ago

If that's the case @Tatsh, why does Clementine gives us the option to "Delete from Disk"? All we want is an way to add an shortcut to this action that already exists, we're not asking that much.

In my case I have a large amount of music and a not so large hard drive and I'd love to quickly delete the musics I don't like so I can move hundreds of music to my cellphone and tablet instead of thousands of music (and I can also have more free space in my computer).

jerobarraco commented 9 years ago

The only reasons i use clementine are because 1) it can delete files and 2) it can move them using an expressions. Those are basic functionalities to me. My library is pretty big (100gib) it would be a total hassle to use a different soft to delete/move songs. What's the meaning to have a "library" if you can't organize it? Also, it is advertised as such. https://apps.ubuntu.com/cat/applications/raring/clementine/

alphapapa commented 9 years ago

Sorry, I think this is a very bad idea. Clementine should be a safe application. It should not be possible to accidentally, permanently delete data with Clementine.

It's bad enough that the menu item exists--at least it has a confirmation prompt. But to have a keyboard shortcut? So if a user accidentally hits the wrong key, or if a small child or a pet mashes the keyboard, his music would be permanently deleted?

Sorry, I just think that's a really bad idea.

Now if the "delete from disk" action were replaced with a "Send to Trash" action, that would be completely different, because you can always go to your trash and restore the files.

jerobarraco commented 9 years ago

why not send it to trash then? the "rm" command exists.

  De: alphapapa <notifications@github.com>

Para: clementine-player/Clementine Clementine@noreply.github.com CC: jerobarraco jerobarraco@yahoo.com.ar Enviado: Martes, 7 de abril, 2015 2:25:36 Asunto: Re: [Clementine] [REQUEST] Shortcut: delete from disk (#4517)

Sorry, I think this is a very bad idea. Clementine should be a safe application. It should not be possible to accidentally, permanently delete data with Clementine.It's bad enough that the menu item exists--at least it has a confirmation prompt. But to have a keyboard shortcut? So if a user accidentally hits the wrong key, or if a small child or a pet mashes the keyboard, his music would be permanently deleted?Sorry, I just think that's a really bad idea.— Reply to this email directly or view it on GitHub.

alphapapa commented 9 years ago

What do you mean? rm does not send to trash. And Clementine does not have support for trash at the moment. I wish it did, but AFAIK, Qt doesn't provide much help for cross-platform trash, and no one seems eager to dive into that abyss.

I think just doing XDG trash wouldn't be a big problem, but then you'd have an inconsistency across platforms...

jerobarraco commented 9 years ago

thats what i meant. rm doesnt handle trash. but rm is known to be dangerous.i think xdg trash would be a better option than nothing. Please use free formats as attachments instead of private counterparts. Thanks. (ie: ods, odt, odp instead of docx or pdf, and 7z instead of winrar) De: alphapapa notifications@github.com Para: clementine-player/Clementine Clementine@noreply.github.com CC: jerobarraco jerobarraco@yahoo.com.ar Enviado: Martes, 7 de abril, 2015 3:04:09 Asunto: Re: [Clementine] [REQUEST] Shortcut: delete from disk (#4517)

What do you mean? rm does not send to trash. And Clementine does not have support for trash at the moment. I wish it did, but AFAIK, Qt doesn't provide much help for cross-platform trash, and no one seems eager to dive into that abyss.I think just doing XDG trash wouldn't be a big problem, but then you'd have an inconsistency across platforms...— Reply to this email directly or view it on GitHub.

alphapapa commented 9 years ago

Issue #1701 is relevant.

mkkabi commented 6 years ago

+1 for delete from disk hotkey if a user sets up the key he takes full responsibility for his actions, right? sudo isn't that safe either, yet you do have it available

alphapapa commented 6 years ago

And sudo requires typing your password.

jerobarraco commented 6 years ago

well i think that if you dont need the feature just dont use it. that doesnt make it less valuable for the people that actually finds it useful.

alphapapa commented 6 years ago

@jerobarraco I don't want to have to worry about accidentally clicking the wrong menu item, or a cat walking across the keyboard, and permanently deleting my music files. Just delete your files to the trash and empty them when you feel like it. Thanks.