clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.77k stars 677 forks source link

Add ability to copy stream URL to clipboard #4774

Open Beep6581 opened 9 years ago

Beep6581 commented 9 years ago

I have a bunch of radio streams in a playlist, and it would be nice to be able to right-click on one and to copy its URL so I can share it. As is, its not only impossible to find the actual URL, but its even impossible to figure out where a stream in the playlist came from (Icecast? SKY.fm? SomaFM? other?) without manually searching for it. Again, this would be a great addition for a right-click context menu.

Please note, the URL should be the one directly to the stream, not some general one. E.g. right-click on "Cafe de Paris" in Internet > SKY.fm, and the closest option to getting a URL is "Open www.sky.fm in browser" but that's a dead end since you then have to search for that station again on their website and their website requires Adobe Flash to play a stream, which more and more people refuse to use for safety and other reasons.

jlsjonas commented 9 years ago

+1 for adding copy URL support for services like soundcloud

snow-born commented 9 years ago

I've been looking into this request. You can add the 'filename' column to your playlist display and this will show you both the URL and the service. Copying the URL might not help as some of them (e.g. Soundcloud) require the Clementine API key. While this would be copied, too, I'm not sure what restrictions there are on the Soundcloud API in terms of sharing it to be used from other applications.

If you are unhappy with the above workaround, I'll attempt to develop the feature and open a pull request.

Beep6581 commented 9 years ago

Thank you for looking into this.

I couldn't see the stream URLs, but found that when I replace "File name (without path)" with "File name" then they appear. This is good to know, but it would be far more practical to be able to right-click an entry and "Copy path" to clipboard, ending up with /music/Mike Oldfield/2003 - Tubular Bells 2003/2 - Fast Guitars.ogg or http://streaming203.radionomy.com:80/OrabidooblogRadio or whatever.

k3dar commented 9 years ago

i too vote... please add "Copy Path/URL" to song context menu, or maybe "Show Information" for showing window with informations about song and with selectable&copyable text... thx :)

suther commented 9 years ago

+10

BTW: You can show the Filename, but you can't copy it!

k0105 commented 8 years ago

On a related note: For Digitally Imported you show di:// domains, which aren't too useful. Replacing this prefix with http://pub7.di.fm/di_ makes those URLs valid and much more useful, e.g. http://pub7.di.fm/di_deeptech [no warranty for linked page]

[Also, let me say that I'm blown away by Clementine - what an amazing player. And even the "less serious" features like Rain or the Nyanalayzer cat simply rock. I hope this player stays around for a long time, because - at least in my opinion - it really blows the competition out of the water. Great work.]

PS: You can drag & drop an entry from the playlist and it will insert the URL. Not as useful as a context menu entry imho, but it also does the job.

snow-born commented 8 years ago

Hi everyone,

Just so you know, I'm working on this on my own fork at the moment. So far, I have completed Soundcloud URL copying. It might be a couple of days before I'm ready to open a pull request.

Beep6581 commented 8 years ago

Great!

snow-born commented 8 years ago

Soundcloud and SomaFM working. I hope to have everything finished by the end of the week.

snow-born commented 8 years ago

Hey all. The pull request is open. I didn't forget about you! :dancers:

doublerebel commented 8 years ago

+1 LGTM

jlsjonas commented 8 years ago

If only someone at the team would actually look at their issue & pull request list sighs

Beep6581 commented 8 years ago

@hatstand

Ferroin commented 8 years ago

@jlsjonas You do realize that nobody who works on Clementine is paid to do so, does so entirely in their free time, and they have no obligation whatsoever to you or anyone else here...

Beep6581 commented 8 years ago

@Ferroin you do realize that that is irrelevant?

jlsjonas commented 8 years ago

@Ferroin yes, I do. I'm just saying that if (out-of-team) community effort is done it would be nice if the team would actually save themselves time by (relatively quickly) verifying code-quality & accepting the pull request so that everyone (including themselves) can benefit from it. Especially if you compare the average merge time ;)

it's just a shame that github marks this as an issue instead of a pull request now that it actually is a pull request

affinityv commented 7 years ago

Podcasts... it would be good to be able to edit/see/copy/export the URL(s) of rss feeds.

A workaround to view the details is to run sqlite3 and query the podcasts table; but this should be able to be done in the UI.

Also, fwiw, the "Edit preferences" dialog.... it would be better if the "Apply" button was greyed out unless a change has been made. But this is out of scope on this particular issue, even though I thought that perhaps I could see the URL(s) in preferences somehow as it wasn't available elsewhere.

Akronix commented 7 years ago

This is specially important for SoundCloud because they state the attributions you have to meet to stream sound from their API. And there, they explicitly say:

3. Link to the SoundCloud URL containing the work
4. If the sound is private link to the profile of the creator