search

clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.72k stars 671 forks source link

N-Band Equalizer #5174

Open tian2992 opened 8 years ago

tian2992 commented 8 years ago

Currently the EQ is hardcoded to 10 bands. https://github.com/clementine-player/Clementine/blob/daddbdea96d059c55ec0d741d52d7dcb783ba638/src/ui/equalizer.h#L35

There are also lots of hardcoded references to 10 bands all across the EQ handler. Could this be increased or even managed dynamically in the UI without breaking the actual EQ audio processing mechanism?

Several issues refer directly or indirectly to this, #3706 #3157

santigl commented 8 years ago

It should be possible, since GStreamer has GstIirEqualizerNBands.

According to the docs:

The n-band equalizer element is a fully parametric equalizer. It allows to select between 1 and 64 bands and has properties on each band to change the center frequency, band width and gain.

On the other hand, I have sent a pull request that implements #3157.