search

clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.77k stars 677 forks source link

Clementine random errors in Sierra #5497

Open DrPhilEvans opened 8 years ago

DrPhilEvans commented 8 years ago

Running Clementine 1.3.1 (and tried with 1.3.2rc1) on MacOS Sierra.

Having just upgraded to Sierra, Clementine is randomly giving errors. I can't trigger it to happen, just periodically it pop up an "internal error" box. If I click 'show details' I get the following:

Exception Name: NSInvalidArgumentException Description: -[SPMediaKeyTap grab]: unrecognized selector sent to instance 0x608000281d10 User Info: (null)

0 CoreFoundation 0x00007fffb30687bb exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fffc77d5a2a objc_exception_throw + 48 2 CoreFoundation 0x00007fffb30e8d84 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132 3 CoreFoundation 0x00007fffb2fdbfc3 __forwarding + 1059 4 CoreFoundation 0x00007fffb2fdbb18 _CF_forwarding_prep_0 + 120 5 clementine 0x0000000101211052 -[SPMediaKeyTap setShouldInterceptMediaKeyEvents:] + 98 6 clementine 0x000000010121120b -[SPMediaKeyTap mediaKeyAppListChanged] + 155 7 clementine 0x0000000101211304 -[SPMediaKeyTap appIsNowFrontmost:] + 228 8 clementine 0x0000000101210bd0 appSwitched + 48 9 HIToolbox 0x00007fffb25580d5 _ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec + 1708 10 HIToolbox 0x00007fffb2557346 _ZL30SendEventToEventTargetInternalP14OpaqueEventRefP20OpaqueEventTargetRefP14HandlerCallRec + 428 11 HIToolbox 0x00007fffb255718f SendEventToEventTargetWithOptions + 43 12 HIToolbox 0x00007fffb25e943e HIToolboxLSNotificationCallbackAllASNsFunc + 571 13 LaunchServices 0x00007fffb41af715 _LSScheduleNotificationFunction_block_invoke_2 + 51 14 CoreFoundation 0x00007fffb2fff3cc CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK + 12 15 CoreFoundation 0x00007fffb2fe06f4 CFRunLoopDoBlocks + 356 16 CoreFoundation 0x00007fffb2fdfe65 __CFRunLoopRun + 917 17 CoreFoundation 0x00007fffb2fdf874 CFRunLoopRunSpecific + 420 18 HIToolbox 0x00007fffb257ff6c RunCurrentEventLoopInMode + 240 19 HIToolbox 0x00007fffb257fda1 ReceiveNextEventCommon + 432 20 HIToolbox 0x00007fffb257fbd6 _BlockUntilNextEventMatchingListInModeWithFilter + 71 21 AppKit 0x00007fffb0c765f5 _DPSNextEvent + 1093 22 AppKit 0x00007fffb13868eb -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1637 23 AppKit 0x00007fffb0c6afbd -[NSApplication run] + 926 24 QtGui 0x000000010322692a _ZN19QEventDispatcherMac13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE + 554 25 QtCore 0x0000000103ec47ea _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE + 394 26 QtCore 0x0000000103ec7067 _ZN16QCoreApplication4execEv + 199 27 clementine 0x0000000100cdbf00 main + 5952 28 libdyld.dylib 0x00007fffc80b1255 start + 1

kevinsumner commented 8 years ago

I'm also seeing this stacktrace on Sierra with Clementine 1.2.2. I haven't figured out how to reproduce it yet, though.

DrPhilEvans commented 8 years ago

Brief extra comment: this error has just occurred for me while Clementine was playing music. The music didn't stop, or even show any sign of the interruption. All that happened was that the Clementine icon in the dock started to bounce, and clicking on it brought up the error. So it's clearly not fatal. It is really annoying though!

ghost commented 8 years ago

Clementine Version 1.3.1 (happens in the latest build Version 1.3.1-224-ga99dc10 as well) Sierra 10.12 (16A323)

Not sure if this is related, but the following happens when I launch iTunes. Or when iTunes is already running and I click its icon in Dock.

Exception Name: NSInvalidArgumentException Description: -[SPMediaKeyTap grab]: unrecognized selector sent to instance 0x60000028dcf0 User Info: (null)

0 CoreFoundation 0x00007fff799417bb exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fff8e0aea2a objc_exception_throw + 48 2 CoreFoundation 0x00007fff799c1d84 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132 3 CoreFoundation 0x00007fff798b4fc3 __forwarding + 1059 4 CoreFoundation 0x00007fff798b4b18 _CF_forwarding_prep_0 + 120 5 clementine 0x00000001043b9902 -[SPMediaKeyTap setShouldInterceptMediaKeyEvents:] + 98 6 clementine 0x00000001043b9abb -[SPMediaKeyTap mediaKeyAppListChanged] + 155 7 clementine 0x00000001043b9bb4 -[SPMediaKeyTap appIsNowFrontmost:] + 228 8 clementine 0x00000001043b9480 appSwitched + 48 9 HIToolbox 0x00007fff78e310d5 _ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec + 1708 10 HIToolbox 0x00007fff78e30346 _ZL30SendEventToEventTargetInternalP14OpaqueEventRefP20OpaqueEventTargetRefP14HandlerCallRec + 428 11 HIToolbox 0x00007fff78e3018f SendEventToEventTargetWithOptions + 43 12 HIToolbox 0x00007fff78ec243e HIToolboxLSNotificationCallbackAllASNsFunc + 571 13 LaunchServices 0x00007fff7aa88715 _LSScheduleNotificationFunction_block_invoke_2 + 51 14 CoreFoundation 0x00007fff798d83cc CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK + 12 15 CoreFoundation 0x00007fff798b96f4 CFRunLoopDoBlocks + 356 16 CoreFoundation 0x00007fff798b8e65 __CFRunLoopRun + 917 17 CoreFoundation 0x00007fff798b8874 CFRunLoopRunSpecific + 420 18 HIToolbox 0x00007fff78e58f6c RunCurrentEventLoopInMode + 240 19 HIToolbox 0x00007fff78e58da1 ReceiveNextEventCommon + 432 20 HIToolbox 0x00007fff78e58bd6 _BlockUntilNextEventMatchingListInModeWithFilter + 71 21 AppKit 0x00007fff7754f5f5 _DPSNextEvent + 1093 22 AppKit 0x00007fff77c5f8eb -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1637 23 AppKit 0x00007fff77543fbd -[NSApplication run] + 926 24 QtGui 0x000000010642992a _ZN19QEventDispatcherMac13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE + 554 25 QtCore 0x00000001070d17ea _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE + 394 26 QtCore 0x00000001070d4067 _ZN16QCoreApplication4execEv + 199 27 clementine 0x0000000103e8d3a4 main + 5620 28 libdyld.dylib 0x00007fff8e98a255 start + 1 29 ??? 0x0000000000000001 0x0 + 1

DrPhilEvans commented 8 years ago

Thanks @andykaycodes - now you've said that I see the same thing, so there's an easy way to reproduce the error.

This isn't the only cause of the error, because I never use iTunes, and Clementine still does give random crashes, but hopefully it will help diagnosis, when someone from the Clemetine devs pick this up...

P

tmikaeld commented 8 years ago

You can also reproduce it like this (On Sierra).

  1. Start Clementine and play music.
  2. Start VLC and play a video with the same Audio Output device.

Then the error will show.

bmt626 commented 8 years ago

I can confirm if you have Clementine open and another media player such as iTunes open and switch between the two it will give this error.

thekev commented 8 years ago

Confirmed. Starting playback in Spotify will trigger the error in Clementine 1.3.1 when both are open. Even if Clementine was freshly launched and not playing anything.

Actually. Both paused, I can switch window focus to Spotify, then back to Clementine, and the error pops up each time Clementine is focused. I don't think it's necessarily related to audio playback. Clementine is receptive to my media keys though. Edit: Actually, the exception occurs when another app is focused, not when Clementine is focused.

`Exception Name: NSInvalidArgumentException Description: -[SPMediaKeyTap grab]: unrecognized selector sent to instance 0x60000009c5c0 User Info: (null)

0 CoreFoundation 0x00007fff7ed6852b exceptionPreprocess + 171 1 libobjc.A.dylib 0x00007fff93440cad objc_exception_throw + 48 2 CoreFoundation 0x00007fff7ede9d34 -[NSObject(NSObject) doesNotRecognizeSelector:] + 132 3 CoreFoundation 0x00007fff7ecdabf5 __forwarding + 1061 4 CoreFoundation 0x00007fff7ecda748 _CF_forwarding_prep_0 + 120 5 clementine 0x00000001024d7902 -[SPMediaKeyTap setShouldInterceptMediaKeyEvents:] + 98 6 clementine 0x00000001024d7abb -[SPMediaKeyTap mediaKeyAppListChanged] + 155 7 clementine 0x00000001024d7bb4 -[SPMediaKeyTap appIsNowFrontmost:] + 228 8 clementine 0x00000001024d7480 appSwitched + 48 9 HIToolbox 0x00007fff7e2580d5 _ZL23DispatchEventToHandlersP14EventTargetRecP14OpaqueEventRefP14HandlerCallRec + 1708 10 HIToolbox 0x00007fff7e257346 _ZL30SendEventToEventTargetInternalP14OpaqueEventRefP20OpaqueEventTargetRefP14HandlerCallRec + 428 11 HIToolbox 0x00007fff7e25718f SendEventToEventTargetWithOptions + 43 12 HIToolbox 0x00007fff7e2e943e HIToolboxLSNotificationCallbackAllASNsFunc + 571 13 LaunchServices 0x00007fff7fe8f715 _LSScheduleNotificationFunction_block_invoke_2 + 51 14 CoreFoundation 0x00007fff7ecfe3ac CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK + 12 15 CoreFoundation 0x00007fff7ecdf424 CFRunLoopDoBlocks + 356 16 CoreFoundation 0x00007fff7ecdef66 __CFRunLoopRun + 1878 17 CoreFoundation 0x00007fff7ecde5b4 CFRunLoopRunSpecific + 420 18 HIToolbox 0x00007fff7e27ff6c RunCurrentEventLoopInMode + 240 19 HIToolbox 0x00007fff7e27fda1 ReceiveNextEventCommon + 432 20 HIToolbox 0x00007fff7e27fbd6 _BlockUntilNextEventMatchingListInModeWithFilter + 71 21 AppKit 0x00007fff7c9765f5 _DPSNextEvent + 1093 22 AppKit 0x00007fff7d0868eb -[NSApplication(NSEvent) _nextEventMatchingEventMask:untilDate:inMode:dequeue:] + 1637 23 AppKit 0x00007fff7c96afbd -[NSApplication run] + 926 24 QtGui 0x0000000104ee592a _ZN19QEventDispatcherMac13processEventsE6QFlagsIN10QEventLoop17ProcessEventsFlagEE + 554 25 QtCore 0x00000001047ac7ea _ZN10QEventLoop4execE6QFlagsINS_17ProcessEventsFlagEE + 394 26 QtCore 0x00000001047af067 _ZN16QCoreApplication4execEv + 199 27 clementine 0x0000000101fab3a4 main + 5620 28 libdyld.dylib 0x00007fff93d1e255 start + 1`

pianopipeman commented 8 years ago

Have the same problem with Clementine with VLC and with iTunes - anyone got any solution??

ghost commented 8 years ago

It seems the problem comes down to some conflict with media keys. All the players use those and Clementine doesn't seem to handle it after Sierra update.

Have the same problem with Clementine with VLC and with iTunes - anyone got any solution?? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clementine-player/Clementine/issues/5497#issuecomment-254563416, or mute the thread https://github.com/notifications/unsubscribe-auth/AIDKDmovQosbHEfTIo5uis8pwesktboLks5q1PQFgaJpZM4KDLdH.

cyberpunklibrarian commented 8 years ago

I had a random error pop up similar to what's described above. Same behaviour, except I wasn't playing any other media, nor did I have another media app open. More than that, I listen to Soma.fm on Clementine all the time and, after the error, the list of stations under Soma.fm was empty. The feeds looked to be there, but the names were blank and double clicking did nothing. I uninstalled, wiped the Clementine folder in Library/Application Support, and reinstalled. Same thing, upon launch, nothing under Soma.fm.

ghost commented 8 years ago

The issue doesn't reproduce in 1.3.1-242-g804d716

tmikaeld commented 8 years ago

Can confirm, works fine in build 242.