clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.79k stars 684 forks source link

Subsonic files don't play - "Playlist finished" #5548

Open aremai opened 8 years ago

aremai commented 8 years ago

Before posting

Please follow the steps below and check the boxes with [x] once you did the step.

System information

Please provide information about your system and the version of Clementine used.

Expected behaviour / actual behaviour

I have successfully added my Subsonic server and have added some songs to the queue. As soon as it tries to stream a song from the subsonic server it says "Playlist finished" without even starting to play this song. Local files just play fine.

This feature works well on my Arch laptop which has the same version (1.3.1).... what am I doing wrong on Ubuntu?!

Steps to reproduce the problem (only for bugs)

aremai commented 8 years ago

are there maybe some logs that I could investigate why it's abruptly ending and not even starting to play?

jonathanchristison commented 7 years ago

Maybe the same as what I had? - https://github.com/clementine-player/Clementine/issues/5360 (problem with self signed certs). I have a fix on my branch for it if you can build from source and aren't concerned about the security implications

aremai commented 7 years ago

It's interesting that the version that I'm running on Arch Linux (clementine 1.3.1-5) doesn't seem to be having issues with self-signed certs.... The latest version for Ubuntu that I could find (bleeding-edge PPA) was Version 1.3.1-245-g5e7dd00

hmm...

jonathanchristison commented 7 years ago

@aremai if you run export GST_DEBUG=2,audio*:5; clementine on the Ubuntu machine does it spit out cert errors? I'd be interesed in why your Arch version is working though, maybe something to do with the underlying cert setup w/ gstreamer

aremai commented 7 years ago

@jonathanchristison

yes, i get the following error (you probably too?!)

WARN souphttpsrc gstsouphttpsrc.c:1578:gst_soup_http_src_parse_status: error: Secure connection setup failed. WARN souphttpsrc gstsouphttpsrc.c:1578:gst_soup_http_src_parse_status: error: Unacceptable TLS certificate (6), URL: https://xxx.com, Redirect to: (NULL) WARN GstEngine:690 Gstreamer error: "Secure connection setup failed." ERROR logging:56 Source ID 11 was not found when attempting to remove it

I redacted the URL ;)

aremai commented 7 years ago

@jonathanchristison is there anything specific that you want me to run on my arch machine? it's working there just fine....

aremai commented 7 years ago

@jonathanchristison ping! is there anything I could test or check on my working arch machine to see what's different there?

aremai commented 7 years ago

any update on this? I would try and help debug this issue...if you tell me how. As said before it works perfectly fine on my Arch Linux but on my Ubuntu (Version 1.3.1-277-gb463e63) it's still not working.....

aairey commented 7 years ago

@jonathanchristison can you not create a PR with your fix for self-signed certs, but also adding an option so that it is user-selectable from the UI?

I think we can get it merged if so, depending on the maintainer. But a PR is so much more helpful.

aremai commented 7 years ago

@jonathanchristison could you please create a PR with your fix from your branch, so that we can get this fixed once and for all? :)

jonathanchristison commented 7 years ago

@aremai @aairey Hey, I'm so sorry I didn't spot these mentions! My PR would be insta-rejected because its not a fix, its a hack to work around the issue. The only work around as i mentioned in my original issue #5360 that i discussed with @hatstand was a fix on the subsonic side (lets encrypt) or extra logic and dialogue to confirm "Yes i know self signed certs are silly and accept the risks".

If i recall vaguely I had to reapply my "fix" for a later version of subsonic as my patch became outdated and couldn't be applied cleanly. I can probably dig it out and see if it applies to HEAD and amend if not but like i say its a hack not a fix so I don't think these would ever be accepted as a PR and rightly so IMO.

Maybe if the devs have any suggestions they'd like to see I could devote a little time to implementing it, though i think the yaks shaved would be many to get up to speed with the project :stuck_out_tongue_winking_eye: