clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.72k stars 671 forks source link

opus: broken tag reader with .ogg file extension #5685

Open fireandfuel opened 7 years ago

fireandfuel commented 7 years ago

Before posting

Please follow the steps below and check the boxes with [x] once you did the step.

System information

Please provide information about your system and the version of Clementine used.

libgstopus and libopus are installed.

Expected behaviour / actual behaviour

expected behaviour: Clementine adds ogg/opus files with .ogg file extension to the music library and tag reader reads the opus tags.

actual behaviour: Clementine's music library and tag reader doesn't support ogg/opus files with .ogg file extension. Music library and tag reader only work with .opus file extension.

The Xiph.Org Foundation defines .opus as the recommended file extension for ogg/opus files, but it should work with .ogg file extension, too.

I checked the ogg/opus file for a valid ogg container, looks fine and the tags are in the file. The file was created by opusenc --bitrate 128 --vbr --title "title" --artist "artist" --album "albumtitle" --date "2016" --genre "genre" source.wav dest.ogg from a wav file.

Steps to reproduce the problem (only for bugs)

Put a ogg/opus file with .ogg file extension in a folder which is added to the music library.

fabi321 commented 1 year ago

This issue is discussed in https://github.com/taglib/taglib/issues/1011 and fixed in https://github.com/taglib/taglib/pull/1013. Bumping the taglib version to 1.13 should fix this.

In the meantime, commenting these lines out and compiling it from source fixes it, too.