ogg tags are case sensitive

clementine-player / Clementine

:tangerine: Clementine Music Player

https://www.clementine-player.org/

GNU General Public License v3.0

3.72k stars 671 forks source link

ogg tags are case sensitive #5788

Open extinctpotato opened 7 years ago

extinctpotato commented 7 years ago

Before posting

Please follow the steps below and check the boxes with [x] once you did the step.

[x] I checked the issue tracker for similar issues
[x] I checked the changelog if the issue is already resolved
[x] I tried the latest Clementine build from here

System information

Please provide information about your system and the version of Clementine used.

Operating System: Manjaro 64bit
Clementine version: 1.3.1

Expected behaviour / actual behaviour

ogg cover art is case sensitive. Clementine won't read cover art from upper-case tag (METADATA_BLOCK_PICTURE). It will read from "metadata_block_picture" just fine.

Steps to reproduce the problem (only for bugs)

Try to tag an ogg file uppercase and lowercase.

By the way, the bug does not occur on Clementine 1.2.3

santigl commented 7 years ago

It seems to be a bug in the TagLib library, which should be already fixed: https://github.com/taglib/taglib/commit/b98a984b66f69cacfcbf259ac3b2d77ea3c9415f.

Unfortunately, there haven't been any releases since before the fix, so you have to compile from source to get it.

extinctpotato commented 7 years ago

If I compiled it and installed to my system, would it fix the issue?

santigl commented 7 years ago

Yes, that should fix it.

extinctpotato commented 7 years ago

It did not. That's because you probably need to build Clementine against taglib from 3rdparty catalog.
I will try to do that and report soon (it it succeeds I think Clementine should update taglib to newer version).

GabrielPrototype commented 6 years ago

I must confirm that this bug also affects me, I'm using fedora 27 and would like to test the latest builds, however, there are only builds for fedora 26

GabrielPrototype commented 6 years ago

I think we should consider that TagLib is a project in the process of deprecation, it has been almost 2 years since the last stable release, and the bug fix in TagLib that would solve this problem was also sent almost 2 years ago and never was incorporated into a release.

There are several other modifications and fixes that have not been incorporated, it is very sad to see. It's been a while since I've used Clementine because of this bug, something that is not even the project's fault.

I tried compiling the taglib with the modifications and also compiling the clementine as well, but I did not succeed due to my lack of knowledge in the technologies used by the two projects.