search

clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.73k stars 675 forks source link

Clementine does not respond to media keys on Mojava #6346

Open enomam opened 5 years ago

enomam commented 5 years ago

I'm running Clementine (1.3.1-580) on MacOS Mojave (10.14.1, 2017 MBP), and it no longer responds to media keys.

I know it used to work on older versions of macOS, but now, hitting the play/pause button opens itunes (annoyingly). Accessibility is turned on for Clementine, so not sure what else I can do.

lassana commented 4 years ago

Same issue. Media keys (next, prev, play/pause) work fine with 1.3.1 from Homebrew, but they do nothing with 1.3.1-967-g922e10bc4.

maxisaninja commented 4 years ago

Same issue as #6384, seemingly due to a change introduced between 1.3.1-243 and 1.3.1-261.

maxisaninja commented 4 years ago

This issue exists because media key functionality was disabled for Mac OS High Sierra and above by commit d19ee714438b1cbc97463b0054d67d0ef44aebbc by @hatstand in an attempt to fix issue #5497. What's puzzling is that the issue seems to have resolved by build 242, but the commit was pushed afterwards; days after other users report the mysterious crash becoming nonreproducible. I've personally been using Version 1.3.1-240-g1a2f6e2 for quite some time without encountering issue #5497.

So in all it seems like media keys have been disabled as a permanent fix of a temporary problem? I made a trivial fork of clementine with this commit reverted to re-enable media keys, but haven't been able to build it for unrelated reasons. If anyone is able to build and test this fork, maybe we can hammer on it a bit before reverting the commit from 2016. If there's no further activity I'll send a pull request to re-enable media keys and perhaps that's enough to resolve this.

One minor note, in #6384 I lamented that Catalina was sending all play button presses to Apple Music and fixing this issue might be pointless. That no longer seems to be the case and media key presses are exhibiting their useful behavior again (acting on the topmost application for which they are relevant), that fix may have been as simple as restarting clementine or my system.

digitalfredy commented 1 year ago

Here running MacOS Catalina 10.15.7 (19H2026) in my old but good MacBookPro mid 2012

If no one was capable to recompile enabling media keys then we have no media keys. If someone have a patch to apply over 1.4.0rc1-211 will be appreciated to share it here.

digitalfredy commented 1 year ago
  1. Download 1.3.1-243 from https://builds.clementine-player.org/mac/
  2. Standard Installation on Apps directory
  3. Give accessibly access to Clementine as mentioned here.
  4. On Finder go to Apps dir, mouse secondary button, open. Twice if does not work.

Notes: