CUE / cuesheet support - Githubissues

Clementine-Issue-Importer commented 10 years ago

From nickpolydor on March 08, 2010 16:12:04

Say we have a continuous DJ mix:

~/MUSIC/A_DJ/A_Mix/a_mix.m3u ~/MUSIC/A_DJ/A_Mix/a_mix.cue ~/MUSIC/A_DJ/A_Mix/a_mix.mp3/.flac/.wav

It would be good for Clementine to read the contents of the cuesheet whenever any of the above files are opened. It would then display the tracklisting in a context window with each track clickable, to seek to the appropriate part of the file.

However, the track navigation buttons should not go to the next track in the cuesheet but the next proper file in the playlist.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=68

Clementine-Issue-Importer commented 10 years ago

From keirangtp on January 19, 2011 07:36:50

This issue was closed by revision r2663 .

Status: Fixed

Clementine-Issue-Importer commented 10 years ago

From keirangtp on January 19, 2011 07:37:34

Everything from now on ( r2663 ) is a bug / feature request. Enjoy!

Clementine-Issue-Importer commented 10 years ago

From st.horde on January 24, 2011 04:24:55

It seems that flac+cue is working fine, but ape+cue is not. If I add a folder containing ape+cue file, an error "LibraryBackend: constraint failed Unable to fetch row" occur.

Clementine-Issue-Importer commented 10 years ago

From keirangtp on January 24, 2011 06:57:11

Could you attach here the .cue + .ape pair?

Clementine-Issue-Importer commented 10 years ago

From st.horde on January 25, 2011 05:35:30

ok, please download the pair in http://www.mediafire.com/?7jo4di6fo8u8z3c (about 80MB)

Clementine-Issue-Importer commented 10 years ago

From keirangtp on January 25, 2011 15:43:49

First, what revision of Clementine are you using? You can check this in 'About Clementine' dialog. I'm asking because I'm on the newest revision and I can't reproduce this - the CUE is playing fine.

If you're on the newest - please remove completely the folder with this CUE from library and then add it again. Then tell me if problem still exists.

Clementine-Issue-Importer commented 10 years ago

From st.horde on January 26, 2011 07:50:28

I am using the version 0.6 r2708 running on Arch Linux (compiled using the build script from http://aur.archlinux.org/packages.php?ID=34981 ), and the problem persist. I have removed ~/.config/Clementine completely before re-installation, but still prompted by the same error when trying to add folder with ape+cue.

btw, I found that Music > Open Media would not show APE file, would it be the cause of this problem?

Clementine-Issue-Importer commented 10 years ago

From keirangtp on January 27, 2011 01:03:47

Do you by any chance live in the future? ;) Current revision is r2704 .

If you select 'Show all files' in the 'Open media' dialog, you'll see the file. I successfully opened it from this dialog, just like I did using drag and drop.

Try this - remove the folder with CUE from library, restart Clementine and then (when you're sure the CUE is not in the library anymore) try to load the file using Clementine's 'Files' tab. What's the result?

Clementine-Issue-Importer commented 10 years ago

From yast4ik on January 27, 2011 04:46:49

sudo pacman -S gstreamer0.10-ffmpeg

st.horde, you do not have this package installed and this is the reason you can't play APE files in Clementine. IMHO.

Clementine-Issue-Importer commented 10 years ago

From keirangtp on February 03, 2011 09:49:07

st.ho... - now I have the same bug you wrote about! I don't know how I missed it earlier. I'll check the problem out and fix it as soon as possible.

Also, your CUE lead me to fixing a few other minor bugs, so thanks. ;}

Clementine-Issue-Importer commented 10 years ago

From keirangtp on February 05, 2011 05:57:02

OK - every issue with your CUE should now be fixed ( r2766 ). Minor problems I've fixed:

your CUE associated song resulted in two tracks when dragging and dropping it's media file and three tracks when using it's CUE (or the other way around)! Now it's always three
when the CUE was not in the library and it's songs were loaded into playlist, after restarting Clementine there was just one song without any tags applied in the playlist. Now when you load the CUE and restart Clementine, everything works as it did before the restart

Also, I've resolved your biggest problem - the library problem. Unfortunately the fix is not letting the song into library... The process which scans your disk for library songs will ignore every APE + CUE pair.

The problem is that Clementine at this point doesn't properly recognize APE files. The lib we use to read tags doesn't know about APEs and marks those songs invalid. You can see the problem when trying to load an APE music file without CUE - you won't be able to because Clementine won't let invalid songs into playlist. On the other hand, all CUE associated songs are marked valid, no matter what the tag lib says, so you are able to load CUE + APE pair into playlist and play it!

Still, from Clementine's point of view the song itself is still invalid and as such we cannot let it to get into library (this results in the 'constraint violated' exceptions you were getting). To sum up:

loading APE with CUE from 'files' tab - possible
putting APE with CUE file into library - impossible

I'll describe all this in the CueSheetSupport wiki page.

Clementine-Issue-Importer commented 10 years ago

From keirangtp on February 05, 2011 05:57:38

This issue is now long dead - if you have other problems with CUEs, please start a new issue!

Clementine-Issue-Importer commented 10 years ago

From audvare on February 07, 2011 03:59:58

Excellent implementation. Just build from source. This works amazingly. I'm so excited for 0.7!

clementine-player / Clementine

CUE / cuesheet support #68