CD playback support

[Clementine-Issue-Importer]

From tomprendergast2 on September 05, 2010 22:09:39

There is currently no CD support in Clementine, so I would like to make a request for it to included in future releases.

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=701

[Clementine-Issue-Importer]

From john.maguire on September 05, 2010 14:26:40

Summary: CD playback support
Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low Component-Sound

[Clementine-Issue-Importer]

From davidsansome on October 18, 2010 10:06:05

Issue 899 has been merged into this issue.

[Clementine-Issue-Importer]

From himynameiszacHandiamapirate on December 31, 2010 08:50:29

Maybe it could show up under "devices", or something? Rename Devices to Media?

[Clementine-Issue-Importer]

From jkflying on January 23, 2011 23:41:34

This is the only issue stopping Clementine from being used as a primary media center.

[Clementine-Issue-Importer]

From tomprendergast2 on March 06, 2011 15:16:31

Amarok just seems to get worse not better so it would be a good opportunity to steal their thunder

[Clementine-Issue-Importer]

From tdockery97 on March 06, 2011 17:50:32

I think CD support should be looked at as a necessary addition

[Clementine-Issue-Importer]

From dreamsofubuntu on March 06, 2011 18:21:09

Agreed CD support should be added =]

[Clementine-Issue-Importer]

From steveh@idnetfreemail.co.uk on March 07, 2011 01:14:31

This would be a very useful addition for me. Clementine is my favourite music player, and CD support would mean I could lose one more unnecessary player from my system.

[Clementine-Issue-Importer]

From cpatrick008 on March 07, 2011 10:37:57

agreed CD support should be added

[Clementine-Issue-Importer]

From transitman on March 13, 2011 17:27:54

I agree, CD support should be added.

[Clementine-Issue-Importer]

From john.maguire on March 17, 2011 08:31:28

Issue 1495 has been merged into this issue.

[Clementine-Issue-Importer]

From tomprendergast2 on March 18, 2011 09:04:11

Can I make a request to move the priority from low to medium?

[Clementine-Issue-Importer]

From keirangtp on March 19, 2011 05:56:21

You can but what actually matters to us is:

• the amount of people who want the feature
• the amount of people for whom an issue crashes Clementine, breaks their Clementine's DB etc.

When it comes to people wanting a feature, CD playback is not so far from the top so I'm sure we'll tackle this at some point.

[Clementine-Issue-Importer]

From rec9140 on March 20, 2011 03:43:24

Any media player should have CD playback. I would rate this a high priority over and above support of any external players which I did not compile support for.

Since amarok tanked, heres the chance to replace it, and thus CD support is a must have.

[Clementine-Issue-Importer]

From tomprendergast2 on March 20, 2011 03:54:50

I would like to make one observation. Amarok 1.4.10 used to work perfectly with CDs and I don't really understand why Clementine, which is based on that release didn't have this functionality in from day one.

[Clementine-Issue-Importer]

From Nickollai on March 20, 2011 11:25:10

I think this feature is not important: CDs are obsolete, just safe OD content as flac files to your HDD/SDD/flash.

[Clementine-Issue-Importer]

From arnaud.bienner on March 20, 2011 11:44:12

I agree with comment 14: Clementine is a music player, so playing CD is important (even if CDs are not very use today). I changed the priority and, maybe, will try to implement this issue if I have enough time. About comment 15: Clementine is inpired by Amarok 1.4, but has been rewritten using Qt4, and don't share lot of code with Amarok. So that's why this feature need to be rewritten.

Status: Accepted
Owner: arnaud.bienner
Labels: -Priority-Low Priority-Medium

[Clementine-Issue-Importer]

From tomprendergast2 on April 23, 2011 16:09:06

I would also like to point out that Windows Media Player is incredibly easy to use, especially when you want to rip a CD. Amarok is a dog by comparison, Clementine would be the number one choice if it was as user friendly as WM Player.

[Clementine-Issue-Importer]

From davidsansome on May 01, 2011 08:23:24

Issue 1837 has been merged into this issue.

[Clementine-Issue-Importer]

From larssonjonas1 on May 05, 2011 12:42:49

I just found out about Clementine. I really like Amarok with folder view but Amarok isn't stable all the time especially in a Gnome DE. Clementine is quick and stable, and I think I'm in love with it ;)

pls add CD support (even if CDs are obsolete it would be useful for many still)

[Clementine-Issue-Importer]

From tomprendergast2 on May 09, 2011 15:19:28

I am asking for two things, firstly the ability to play CDs and secondly to able to rip CDs easily. If that was done then Clementine would be the open source equivalent of Windows Media Player.

[Clementine-Issue-Importer]

From anthonyloomis on May 29, 2011 12:45:13

Requesting the ability to play cds and rip cds. It would catapult Clementine to the best player I've ever used, hands down.

[Clementine-Issue-Importer]

From arnaud.bienner on June 09, 2011 16:14:42

CD support is now present ( r3372 ). Currently, it works like in Amarok1.4 (Music -> Open CD). Maybe we could also add CDs in Devices tab? Also, even if it seems to work well for now, there is maybe (certainly?) some bugs to fix or some enhancements to do. If you want to test, you're welcome ;)

Status: Started

[Clementine-Issue-Importer]

From arnaud.bienner on June 14, 2011 10:43:07

Labels: Milestone-1.0

[Clementine-Issue-Importer]

From schizosfera on July 04, 2011 04:56:49

all i get is a dialog: "Error while loading audio CD" when selecting "Music" -> "Open audio CD..."

console output:

13:48:17.354 INFO DeviceManager:393 Device added: "Gio//cdda/619577344" 13:48:29.926 INFO SongLoaderInserter:95 Loading audio CD... 13:48:29.945 ERROR SongLoader:115 Error while changing CDDA GstElement's state

the device manager displays an unmounted audio disc. the console output when attempting to mount:

13:49:07.922 INFO SongLoaderInserter:95 Loading audio CD... 13:49:07.946 ERROR SongLoader:115 Error while changing CDDA GstElement's state 13:51:21.325 ERROR OperationFinished:60 Mount/unmount error: mount: /dev/sda3 already mounted or /media/Foo busy mount: according to mtab, /dev/sda3 is already mounted on /media/Foo

dev/sda3 is a local (already mounted) HDD.

[Clementine-Issue-Importer]

From schizosfera on July 04, 2011 05:11:32

maybe it's worth mentioning that vlc plays the cds, while gnome mplayer managed to crash gdm when attempting to play a cd

[Clementine-Issue-Importer]

From arnaud.bienner on August 04, 2011 17:16:33

This issue was closed by revision f7859f591c80 .

Status: Fixed

[Clementine-Issue-Importer]

From arnaud.bienner on August 05, 2011 06:08:49

Now, CD devices are also displayed in devices tab (on the left). Previously, they were visible, but handle through Gio. (I'm not sure, but I think this may have lead to some of the errors mentioned in comment 25). I'm not sure we will keep both ways (CD in devices tab and and "Music->Open Audio Cd") to access CDs: only in devices tab will be fine I believe.

It is working well on my side; but I wasn't able to test on every distribution/OS, so if you want to do so using the builds ( http://builds.clementine-player.org ), don't hesitate ;)

[Clementine-Issue-Importer]

From schizosfera on August 05, 2011 07:00:24

does not comile here (clean build):

clementine-player/src/devices/cddalister.cpp:18:23: fatal error: cdio/cdio.h: No such file or directory compilation terminated. make[2]: * [src/CMakeFiles/clementine_lib.dir/devices/cddalister.cpp.o] Error 1 make[2]: * Waiting for unfinished jobs.... make[1]: * [src/CMakeFiles/clementine_lib.dir/all] Error 2 make: * [all] Error 2

[Clementine-Issue-Importer]

From arnaud.bienner on August 05, 2011 07:15:05

You should install libcdio-dev package.

[Clementine-Issue-Importer]

From schizosfera on August 05, 2011 07:36:05

thanks. it compiles (and plays) now but the display is incorrect - see attachment: 11 tracks on the cd, 22 tracks displayed, 22 tracks added to the playlist, unnecessarily grouped.

Attachment: audio_tracks.jpg

[Clementine-Issue-Importer]

From tomprendergast2 on August 06, 2011 04:23:11

I finally managed to get Clementine to work with Ubuntu 11.04, but cannot get it to work with Linux Mint 10 KDE.

[Clementine-Issue-Importer]

From arnaud.bienner on August 08, 2011 08:22:19

@schizosfera: your problem sounds strange... I never encountered something similar during my testing :( Does it happens every time? Or just randomly? Also, what OS are you using?

[Clementine-Issue-Importer]

From schizosfera on August 08, 2011 09:06:20

i'm on ubuntu 11.04. until now it happened each time, with any audio cd. also it's not only the songs which are duplicated but also the device (see screenshot). also, the disc was in the ROM device not in the RAM device as clementine displays it. if i put it in the RAM device, clementine won't read it (it will just display "16 songs" underneath the first RAM device in the list - as in the 2nd screenshot).

Attachment: duplicate_device.png duplicate_device_2.png

[Clementine-Issue-Importer]

From schizosfera on August 08, 2011 09:08:41

update: now, after reinserting the disc in the first drive (ROM) i finally got this. i'm really confused...

Attachment: total_mess.png

[Clementine-Issue-Importer]

From arnaud.bienner on August 08, 2011 11:11:03

OK. I've some ideas this may come from. Will try to correct this asap.

[Clementine-Issue-Importer]

From arnaud.bienner on August 10, 2011 01:40:40

The problems mentioned above should have been corrected now. So if you want to give it another try... ;) Btw, thank you very much for your feedback, it's very much appreciated!

[Clementine-Issue-Importer]

From schizosfera on August 10, 2011 02:43:55

it looks a lot better:

• the (cd --> device) mapping is correct this time
• there are no more duplicate songs displayed

the only visible defect is that my RAM device still appears twice in clementine (the first RAM entry seems to be only a dummy and does nothing).

you're welcome! btw: i also actually almost never listen to cds - i usually rip them and listen to the flacs. i'm just testing because i'd like clementine to stay memory leak free :P (and it's currently the only way for me to be somehow useful)

[Clementine-Issue-Importer]

From schizosfera on August 10, 2011 02:52:01

i just noticed one more thing: see (in the attached screenshot) the "11 songs" near both devices while a single cd is inserted.

Attachment: device_confusion.png

[Clementine-Issue-Importer]

From schizosfera on August 10, 2011 02:57:24

update: this could be some other problem (unrelated to the device confusion) as the "11 songs" info seems to remain visible after the cd is removed.

[Clementine-Issue-Importer]

From arnaud.bienner on August 10, 2011 05:20:43

I'm aware of the "%n songs" that remains visible. I will have to fix it.

About the "dummy" device, maybe it remains from previous releases you have used. Can you try to right-click->"Forget this device" on it (or better, to make it really clean, on all CD devices) and see afterwards which devices appear? Also, even if I already try to detect cases where CD devices are discovered multiple times, maybe I missed some.

[Clementine-Issue-Importer]

From schizosfera on August 10, 2011 06:17:21

selecting "forget this device" only resets the text and disables the "forget this device" menu entry. it has no other effect here: i still have both entries for the same disc device.

maybe it will help to isolate the problem if other users also test a bit.

[Clementine-Issue-Importer]

From schizosfera on August 10, 2011 06:42:22

ubuntu natty.

ls /dev/sr* /dev/sr0 /dev/sr1

hatstand suggested adding qLog(Debug) << device; to cddalister.cpp:110, right after the device string is inited. here's the output: 15:34:00.194 DEBUG CddaLister:111 "/dev/scd0" 15:34:00.194 DEBUG CddaLister:111 "/dev/sr0" 15:34:00.194 DEBUG CddaLister:111 "/dev/sr1"

ls -l /dev/scd* lrwxrwxrwx 1 root root 3 2011-08-10 11:39 /dev/scd0 -> sr0 lrwxrwxrwx 1 root root 3 2011-08-10 11:53 /dev/scd1 -> sr1

so why does only one come up? :/ i hope this helps...

[Clementine-Issue-Importer]

From schizosfera on August 10, 2011 07:17:23

"hatstand: QFileInfo info(device); if (info.isSymLink()) { continue; } might be good enough"

it actually fixed the problem (for me) and it also matches the strcmp("/dev/cdrom") case here (which in my case are just links to the sr* devices).

i also noticed that "^/dev/rdisk[0-9]$" matches only the first 10 such devices (should it maybe be "^/dev/rdisk[0-9]+$" ?). but i have no clue how cds with more than 10 tracks appear on macos.

[Clementine-Issue-Importer]

From arnaud.bienner on August 10, 2011 07:20:54

Yes, indeed, I think this is the way to go: we should check for symbolic links and ignore them.

[Clementine-Issue-Importer]

From john.maguire on August 10, 2011 08:07:19

The regex matches actual drives, tracks show up as /dev/rdisk1s1 for instance. I somewhat doubt anyone has more than 10 drives.

[Clementine-Issue-Importer]

From arnaud.bienner on August 11, 2011 05:04:36

I've added the symbolic link check ( revision f963ae524aa1 ). So the last known problem that remains is the songs count which is not reset to zero when device is removed.

[Clementine-Issue-Importer]

From john.maguire on August 11, 2011 05:49:51

I also need to write some Mac-specific code as libcdio doesn't detect drives until they contain a CD.

[Clementine-Issue-Importer]

From tomprendergast2 on August 28, 2011 03:21:16

Could somebody tell me why I still cannot get a CD to play with Linux Mint 10 KDE? I am getting the latest updates for Clementine but it still doesn't work.

[Clementine-Issue-Importer]

From arnaud.bienner on August 29, 2011 00:51:42

This feature will be available in next release (1.0), and isn't available in the current stable release.