search

clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.68k stars 669 forks source link

Fix build: add zlib to deps where it's used #7238

Closed DarthGandalf closed 1 year ago

DarthGandalf commented 1 year ago

Ref https://bugs.gentoo.org/887105

hatstand commented 1 year ago

If zlib is only required by Qt5Network then shouldn't this be pulled in via the various Qt5 cmake rules?

DarthGandalf commented 1 year ago

https://github.com/clementine-player/Clementine/blob/9ef681b0e9e945c662905c1ffc5e179dd8e04d3c/3rdparty/qtiocompressor/qtiocompressor.cpp#L48 requires it too

hatstand commented 1 year ago

https://github.com/clementine-player/Clementine/blob/9ef681b0e9e945c662905c1ffc5e179dd8e04d3c/3rdparty/qtiocompressor/qtiocompressor.cpp#L48

requires it too

I think adding z to the target_link_libraries() in that directory's CMakeLists.txt would fix that. It's better than doing it globally as it should take care of the ordering too I think.

DarthGandalf commented 1 year ago

Yes, I agree, that's cleaner. Done.