clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.68k stars 670 forks source link

lyrics search: lyrics.com returning placeholder, breaking functionality #7287

Open marcusmueller opened 9 months ago

marcusmueller commented 9 months ago

Before posting

Please follow the steps below and check the boxes with [x] once you did the step.

System information

Please provide information about your system and the version of Clementine used.

Expected behaviour / actual behaviour

The lyrics search uses results from the first service to return an actual result

Steps to reproduce the problem (only for bugs)

play any song with the "Song info" tab open, and lyrics.com enabled in the preferences

you get

Get the lyrics for Cold (but im still here) at Lyrics.com

instead of an actual result

Desirable Behaviour

rejection of that result (which essentially means removing lyrics.com from the search from now). As noticed in #6677, it's time to go through the list of search engines and probably throw out nearly all of them.