clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.68k stars 670 forks source link

Handling of "Next Track" signal is incorrect #7326

Open Solbeziel opened 1 month ago

Solbeziel commented 1 month ago

Before posting

Please follow the steps below and check the boxes with [x] once you did the step.

System information

Please provide information about your system and the version of Clementine used.

Operating environment is Debian/KDE Plasma.

Expected behaviour / actual behaviour

expected: Issuing a Next Track signal (by clicking button or pressing MediaNext key/hotkey) causes Clementine to seek to the next track in the playlist under any and all circumstances where there is a next track to play.

actual: Issuing a Next Track signal is functionally equivalent to manually seeking to the end of the current track. Therefore in "Stop after each track" repeat mode, the functionality is identical to issuing a Stop command, and confusingly inconsistent with the behaviour of the "Previous Track" command. This results in an inability to skip forward through playlist in "Stop after each track" play mode.

Steps to reproduce the problem (only for bugs)

  1. Create a playlist
  2. Set playlist repeat mode to "Stop after each track" (menu:Playlist|Repeat mode|Stop after each track)
  3. Try to skip forward and backward in the playlist using Previous/Next track buttons.
  4. Compare this behaviour with manually seeking to end of track (using position slider)
  5. Compare also to pressing "Stop" button, either in interface or on keyboard. In particular note that skipping backward while in the Stopped state anywhere moves to the last track in the playlist. This behaviour might be worthy of a separate bug report.
Solbeziel commented 1 month ago

I notice also that in "Stop after each track" mode, after a track reaches the end and stops, pressing Play skips to the next track. This seems like unnecessary and possibly confusing behaviour, and is inconsistent with the behaviour of the Play button when the track is manually stopped with the Stop button. It is my opinion that the Play command should only ever play the currently selected track and never perform the function of the Next Track command.