clementine-player / Clementine

:tangerine: Clementine Music Player
https://www.clementine-player.org/
GNU General Public License v3.0
3.77k stars 677 forks source link

copy album covers to portable devices (e.g. ipods) #777

Open Clementine-Issue-Importer opened 10 years ago

Clementine-Issue-Importer commented 10 years ago

From multicolor.mood on September 20, 2010 23:17:01

Are you planning to add covers' support for ipod?

Original issue: http://code.google.com/p/clementine-player/issues/detail?id=777

Clementine-Issue-Importer commented 10 years ago

From john.maguire on September 24, 2010 05:51:34

Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low Component-Devices

Clementine-Issue-Importer commented 10 years ago

From flyingisfun1217 on September 29, 2010 10:03:05

Would love to see this also.

Clementine-Issue-Importer commented 10 years ago

From davidsansome on November 21, 2010 12:21:34

Issue 819 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From davidsansome on December 21, 2010 04:49:29

Issue 1157 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From keirangtp on December 21, 2010 06:44:07

Summary: copy album covers to portable devices (e.g. ipods)

Clementine-Issue-Importer commented 10 years ago

From goetzchrist on January 21, 2011 09:35:16

Having the album covers copied to the media device is very useful, especially when browsing albums with Cover Flow or such modes.

Many people have more facility to find things by looking to an icon or image, than by reading a text.

Clementine-Issue-Importer commented 10 years ago

From davidsansome on January 28, 2011 13:38:06

Issue 1383 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From hyartep on February 25, 2011 08:06:13

i'm do not know, how ipod handles cover art in files, but if cover art is embedded in id3 tag (maybe as an option) many other devices supporting this standard could use this.

Clementine-Issue-Importer commented 10 years ago

From CoachArnold on March 30, 2011 06:32:37

THis would be MAJOR HUGE !!!!!!!!!!!!

Clementine-Issue-Importer commented 10 years ago

From cclonch on April 13, 2011 07:08:12

Maybe this can be fixed with issue 415 if the album art is embedded in the metadata? Transcoding to my Moto Droid is annoying that the art must be manually copied. I would like to see this bumped to a higher priority in hopes of making it into a release sooner rather than later.

Clementine-Issue-Importer commented 10 years ago

From CoachArnold on April 13, 2011 07:23:31

The problem is alot of people (myself included) use FLAC and other codecs that don't allow embedded album art. Really the best thing here would be to put a copy of the cover in the album folder.

Clementine-Issue-Importer commented 10 years ago

From rfc469 on April 13, 2011 08:35:19

Will that work for ipods and iphones? Maybe it could embed the album art in the formats that support it, or make it an option.

Clementine-Issue-Importer commented 10 years ago

From CoachArnold on April 13, 2011 09:01:41

Why does the ALbum Art need to be embedded at all??

Clementine-Issue-Importer commented 10 years ago

From cclonch on April 14, 2011 03:48:39

Ideally this should cover multiple cases: embedded art, separate art or both. However, most formats including FLAC do support embedded art. Music players on the other hand may not be able to show it; Winamp on Android can not. Maybe my real issue is I need Clementine on my Droid?!

I was just hoping to gain this request traction by associating it with one of a higher priority and a set milestone.

Clementine-Issue-Importer commented 10 years ago

From thad.humphries on May 16, 2011 08:35:46

+1 This was in Amarok 1.4, and I dearly miss the capability.

Clementine-Issue-Importer commented 10 years ago

From musicalbento on May 23, 2011 10:25:12

Was this ever implemented? I don't want to have to use gtkpod as a workaround for adding my album art after adding the songs, but I really do want my album art (it makes things so much easier to find honestly)

Clementine-Issue-Importer commented 10 years ago

From petr.kubat on May 27, 2011 02:45:48

It is really essential to embed cover somehow - anytime you do something with your library every clementine-fetched-cover is lost! It would be perfect to add the cover to metadata when possible and also add it to the album folder. And when fetching the covers - look for the folder-cover first.

Clementine-Issue-Importer commented 10 years ago

From juan.baptiste on May 27, 2011 07:25:57

Yes I can confirm that if you add a cover to a song with clementine and then transfer it to your ipod it will be lost. Not sure if it won't loose covers added to the file with other programs, I'll have to check that.

Clementine-Issue-Importer commented 10 years ago

From juan.baptiste on June 12, 2011 00:36:36

Confirmed, covers embedded with other programs will be lost also upon transfer. I usually use mp3tag for Windows and then transfer with itunes which works fine, adding the covers with mp3tag to the mp3 files and then transfering them with clementine, the covers will be lost.

Clementine-Issue-Importer commented 10 years ago

From TimLIVID on July 05, 2011 03:31:02

I have often thought one are where Clementine is lacking is it's inability to embedded album art into the MP3 file. Looking forward to that feature coming.

Clementine-Issue-Importer commented 10 years ago

From schizosfera on July 05, 2011 04:03:27

note that embedding the cover in audio files and copying the cover to the portable device are two separate features. i personally would be glad if at least copying the cover would work. embedding would be the next step as this also requires transferring (or generating) the audio metadata during the transcoding process.

Clementine-Issue-Importer commented 10 years ago

From jiml@eldorado.org.uk on July 08, 2011 06:21:10

I would also like to have cover art copied to device with perhaps the additional option to shrink the cover art to a size more suitable for the device (therby saving space)

Clementine-Issue-Importer commented 10 years ago

From david.toropov on July 13, 2011 16:02:44

please add the capability to import album artwork onto ipods!

Clementine-Issue-Importer commented 10 years ago

From CoachArnold on July 13, 2011 16:20:07

Hope this is working out ....... this is still number one on my want list along with a script framework....

Lookin good

thanks

T

Clementine-Issue-Importer commented 10 years ago

From kadaimx on August 09, 2011 13:37:55

For ipods, please referrer to libgpod and gtkpod. the library actually can set (with no big problem) the album cover as long it has the feature compiled on it.

Also gtkpod is able to tell the ipod when a track have lyrics when the song have the "USLT" or any frame alike that tells this.

This sure is not a hard thing to do.

Clementine-Issue-Importer commented 10 years ago

From ginolovesyou on September 27, 2011 04:01:31

Please bump priority on this! LOOK AT ALL THE COMMENTS!

Clementine-Issue-Importer commented 10 years ago

From CoachArnold on September 27, 2011 05:28:45

Remember that this is not a request for ipod or mp3, its s generic request. Album art converted if necessary and copied to a device .

Thanks for all the hard work .... Still the best !

T

Clementine-Issue-Importer commented 10 years ago

From jan@essert.name on October 20, 2011 06:19:02

amarok 1.4 did this automatically for iPods, if the cover was embedded in the ID3 tag. Perhaps you could at least restore this functionality?

Clementine-Issue-Importer commented 10 years ago

From mittiprovence on November 04, 2011 00:45:11

I'm using Clementine 0.7.1 and saw the covers of my album not copied to my iPod Touch.

That's too bad. I will have to find another software to maintain my iPod library then.

Covers are a must on iPods.

Clementine-Issue-Importer commented 10 years ago

From CoachArnold on November 04, 2011 12:59:07

Seems no one cares about a fairly easy issue ...... guayadeque has integrated cover transfer support really well .... http://guayadeque.org/forums/index.php?p=/page/Home

Clementine-Issue-Importer commented 10 years ago

From goetzchrist on November 04, 2011 14:35:51

Is it possible to borrow that piece of code from Amarok?

Clementine-Issue-Importer commented 10 years ago

From kadaimx on November 04, 2011 16:15:22

On portable devices that read the cover art from the MP3 file (like some MTP players, and generic players) clementine works well because the Cover is dragged from the file itself and not from a database.

None the less, the implementation of the of the libgpod library on clementine lacks the feature to copy the album art to the device even if it exist, maybe because it was tested/developed without it.

One of the solutions I have found to this issue is to use another tool like GTKPod (the tool thatoriginally used libgpod) to re-scan the files and then set on them the proper cover art... but that is a time-consuming operation.

It is posible to have clementine to handle the Cover art for the ipod? Yes, but someone might need to lurk into the code and find out the exact piece of code and port it to Clementine on its calls to the libgpod API.

Clementine-Issue-Importer commented 10 years ago

From deckoff on December 03, 2011 00:48:10

This issue is still not fixed for me. Clementine 1.0 rc1, iPod Classic 120GB, black. I do think this issue should be at least medium, nobody cares for this issue for at least an year. Ipods for good or bad are the best-selling mp3 players, so this should be issue for quite a lot of people,

Clementine-Issue-Importer commented 10 years ago

From gleugner on February 24, 2012 11:37:46

I created a patch for that issue. I added the main DB to retrieve cover informations and write them with libgpod. Here it solves the issue. --georg

Attachment: 0001-added-support-for-copying-covers-to-ipods.patch

Clementine-Issue-Importer commented 10 years ago

From juan.baptiste on February 26, 2012 21:00:31

The patch works if the cover is on the same directory as the music files, but if the cover is embedded on the files (tested with mp3) the cover is lost on transfer.

Clementine-Issue-Importer commented 10 years ago

From juan.baptiste on March 05, 2012 20:37:04

No one else has tested this patch ? it's incredible that after year and a half someone takes the time to start fixing this issue, and no one else from the people following this bug has tested the patch ?

then don't complain if this issue doesn't get fixed !!

@georg, as I said in my previous comment, it seems that the only thing missing to your patch is support for covers embedded in the music files, it works with covers on clementine database. Do you think you can improve your patch to handle this case ?

Clementine-Issue-Importer commented 10 years ago

From schizosfera on March 06, 2012 14:27:35

@36: not everyone opening or starring an issue is a developer or has the means, knowledge and time to apply patches ;) thanks though for testing the patch

Clementine-Issue-Importer commented 10 years ago

From deckoff on March 07, 2012 00:17:43

I am willing to test it, but I need some general push how to set up development environment and apply a patch. A few web links to get me started, nothing more.

Clementine-Issue-Importer commented 10 years ago

From schizosfera on March 07, 2012 00:26:51

@38: http://code.google.com/p/clementine-player/wiki/CompilingFromSource is a good place to start. if you have any problems, don't hesitate to ask in #clementine on freendode. people in there are usually willing to help - just have some patience as it might take a while for people to react

Clementine-Issue-Importer commented 10 years ago

From deckoff on March 07, 2012 05:57:19

I cant apply the patch to the current git version http://pastebin.com/MngytfDQ

Clementine-Issue-Importer commented 10 years ago

From deckoff on March 08, 2012 06:06:46

What is the version for which this patch was written?? I would really love to help here :)

A simple work-around for folders without cover images in them would be to get the cover from the tag out of the first audio file in a given folder to the folder, and proceed with sync after this :)

Clementine-Issue-Importer commented 10 years ago

From eveigh on March 10, 2012 21:26:08

Is this issue fixed, or, more importantly, will it ever be fixed? Love the player, hate how it ignores album art.

Clementine-Issue-Importer commented 10 years ago

From wallner1986 on March 11, 2012 17:16:05

modified patch a little bit (didn't compile for me), works now with b676676b9a44063bbceda9bd8022900ca2455ab2, so i named it like that...

Attachment: albumart_b676676b9a44063bbceda9bd8022900ca2455ab2.patch

Clementine-Issue-Importer commented 10 years ago

From deckoff on March 12, 2012 14:14:13

I can confirm that applying this patch will sync cover to ipod, but:

Clementine-Issue-Importer commented 10 years ago

From gleugner on March 13, 2012 15:48:49

Currently just covers are from manager are used. Setting embedded covers is easy, but I have problem loading them before, because there is currently just an asynchronous method to load them and I don't want to bother with queues thread queues...

Can you tell me how to use "properly named jpgs" : way...

Clementine-Issue-Importer commented 10 years ago

From arnaud.bienner on March 13, 2012 16:34:53

Labels: PatchAttached

Clementine-Issue-Importer commented 10 years ago

From deckoff on March 14, 2012 07:39:02

@comment 45 What I meant is that you have to "set" the album cover to the album. It is not enough to just save a picture file to the album folder and name the file "Album name here".jpg. When one saves a file to the hard disk via the Clementive cover manager, this is the generated file name.
Best way will be Clementine to use the covers that are stored in the ide2 tag itself. This way the user will not have to play with doing anything else: setting cover or anything else. I dont know how easy or hard is this to be done. I am not sure how the sync plugin works, but I might probably come with some ideas for easing the solution. I can write some javascript and bash, might probably coem with some general ideas.

Clementine-Issue-Importer commented 10 years ago

From wallner1986 on March 15, 2012 15:55:38

The covers will sync.

I did it successfully with a "cover.jpg" in each album folder. the only thing that messes things up is embedded mp3 tags,

i removed them ( like mentiod here http://blogs.igalia.com/aperez/2011/11/recipe-removing-embedded-album-art-from-mp3s/ )

Clementine-Issue-Importer commented 10 years ago

From davidsansome on March 16, 2012 03:45:00

Issue 2809 has been merged into this issue.

Clementine-Issue-Importer commented 10 years ago

From davidmaxwaterman on March 16, 2012 03:49:12

I hope someone can comment on the suggestion in issue 2809 , which, I think is somewhat more flexible that described in this issue - ie will work for more players than just ones made by Apple.