Shiny assessment feedback

[jonekeat]

Hi Clement, thanks for attempting the shiny assessment, please find my feedbacks below:

1. The interface fully fulfilled all requirements, user is able to input some data, calculate and visualize result all in the app, well done!

2. The app is also able to handle dynamic number of loss year & development year, which is very nice!

3. There are a lot of empty spaces on the top right corner, but user need to scroll up & down to check input & output. Maybe the UI can be further improve?

4. For the tail factor input, we should specified the min, max and step arguments, maybe should put from 1 to 2, and the each step should increase/decrease by 0.1 instead of 1 (the default) https://github.com/clementtcy/R-Shiny-Training-Assessment/blob/91832bb9f57fa1cb701d1a4449dbc1983ddcbe00/app.R#L5

5. Since the output number are currency values, we can format it using accounting format (put thousand separator), especially y-axis of graph & table cells

6. The table formatting is quite good, but we can enhance the table cell formatting, like putting different cell/background color to differentiate which cell is input values and which is projected.

[selwinchrisany]

Here is my feedback:

1. There is a repetition of code. This can be improved by using reactive value for this part https://github.com/clementtcy/R-Shiny-Training-Assessment/blob/main/app.R#L51-L77

2. The table output can be improved by adding column name & row name (i.e. ''Loss Year" & "Development Year")

3. The plot output can be improved by formatting the y-axis so that development year is not in decimal