search

clemfromspace / scrapy-selenium

Scrapy middleware to handle javascript pages using selenium
Do What The F*ck You Want To Public License
919 stars 348 forks source link

Fixes TypeError: __init__() got an unexpected keyword argument 'firefox_options' #101

Open abhinav-bhardwaj opened 2 years ago

abhinav-bhardwaj commented 2 years ago

Fixes #100

Tested on Selenium Version - 4.0.0 scrapy-selenium version - 0.0.7 Scrapy version - 2.5.1 Python version - 3.8 OS - Ubuntu 20.04.2 LTS

RomanBukin commented 2 years ago

I want to use options (for example, '-headless'), but now they are ignored.

abhinav-bhardwaj commented 2 years ago

I want to use options (for example, '-headless'), but now they are ignored.

Did you try the latest code update that I have committed?

Zincious commented 2 years ago

Thanks for this, works like a charm after the file change.

RomanBukin commented 2 years ago

Did you try the latest code update that I have committed?

Yes, now it works. Thanks.

damienkilgannon commented 2 years ago

While waiting on this to be merged ... which version of selenium & scrapy-selenium don't have this issue? thanks

KonstantinKlepikov commented 2 years ago

so, problem is in selenium version:

the browser option parameter firefox_options was deprecated in Selenium 3.8.0

If you use newest version: i tested the package today - the problem is in place.

k0mmsussert0d commented 2 years ago

Hello! Any chance for this to get merged?

samlexxy commented 2 years ago

@clemfromspace any idea when this will be merged and updated?

wunewww commented 1 year ago

This PR should be merged as soon as possible. it is critical. ^ ^

samlexxy commented 1 year ago

@abhinav-bhardwaj can you please review and merge this?

abhinav-bhardwaj commented 1 year ago

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

samlexxy commented 1 year ago

@abhinav-bhardwaj can you please review and merge this?

@samlexxy actually I'm not the maintainer of this repo, so I can't merge. Though other people can review and approve this but they also can't merge.

perhaps @clemfromspace will be kind enough to look into this

ahmedraxa23 commented 1 year ago

self.driver = driver_klass(**driver_kwargs) TypeError: WebDriver.init() got an unexpected keyword argument 'executable_path' ANY SOLUTUION?

samlexxy commented 1 year ago

self.driver = driver_klass(driver_kwargs) TypeError: WebDriver.init**() got an unexpected keyword argument 'executable_path' ANY SOLUTUION?

you'll need to edit your scrapy_selenium middle file..

follow this link https://github.com/clemfromspace/scrapy-selenium/pull/101/files