[refactoring] Show documentation and Find declaration still fail when not in a ST project

[clemos]

Still the good old :

Traceback (most recent call last):
  File "./sublime_plugin.py", line 362, in run_
  File "./haxe/commands/find_declaration.py", line 58, in run
  File "./haxe/commands/find_declaration.py", line 144, in run1
  File "./haxe/commands/find_declaration.py", line 49, in prepare_build
TypeError: unsupported operand type(s) for +: 'NoneType' and 'str'

BTW, I'm quite sorry I haven't been able to help you much lately; I've been very busy on non-Haxe projects these days, and almost didn't work either on or with the bundle.

Anyway, I believe it will soon be time to make your version the master version. What do you think ?

You've made a pretty awesome work anyway, thanks so much ;)

[frabbit]

hmm strange, i cannot reproduce this behaviour, but it seems to be related to temp file creation. I changed the temp file creation (uses now the os temp dir instead of the project dir), but i'm not sure if that fixes the problem. Could you try the latest version? And if you encounter the problem again i need to know if you use a regular hxml-build, a nme-build or an openfl-build.

BTW, I'm quite sorry I haven't been able to help you much lately; I've been very busy on non-Haxe projects these days, and almost didn't work either on or with the bundle.

Not a big deal, we all know that time is always a huge problem ;)

Anyway, I believe it will soon be time to make your version the master version. What do you think ?

I'm fine with making this the master version, i would also like to introduce a new development branch, because i can't check every change on every os and project and the dynamic nature of python doesn't make it easier ;). What do you think about having a dev branch and only pushing stable versions to master?

You've made a pretty awesome work anyway, thanks so much ;)

Thx a lot ;)

[frabbit]

if its ok you i make this the master version and also create a development branch?

[clemos]

Hi Heinz, I've tested the latest version. I get another error :

Traceback (most recent call last):
  File "./sublime_plugin.py", line 362, in run_
  File "./haxe/commands/find_declaration.py", line 58, in run
  File "./haxe/commands/find_declaration.py", line 144, in run1
  File "./haxe/commands/find_declaration.py", line 40, in prepare_build
  File "./haxe/temp.py", line 55, in create_temp_path_and_file
  File "./haxe/temp.py", line 40, in create_file
  File "./haxe/exceptions.py", line 7, in __init__
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 26: ordinal not in range(128)

Now this error is just because my project's path has special characters in it (é) and the exception GetRelativePathException tries to concatenate it in an ascii string.

So anyway, I've investigated it a bit further. The error only appears when a wrong build is selected, ie when the file is not in the build's classpath. This is correct behaviour somehow, but should probably raise an error message or something rather than crash silently.

As for branches: I agree it would be nice to create a dev branch. Now there are still a few bugs in the refactoring branch that need to be fixed before merging it to master, I guess. Let me know if I can do anything.

Regards, Clément

[frabbit]

So anyway, I've investigated it a bit further. The error only appears when a wrong build is selected, ie when the file is not in the build's classpath. This is correct behaviour somehow, but should probably raise an error message or something rather than crash silently.

Ok, yes some exceptions are currently not properly handled, will try to fix this problem.

As for branches: I agree it would be nice to create a dev branch. Now there are still a few bugs in the refactoring branch that need to be fixed before merging it to master, I guess. Let me know if I can do anything.

Reporting and tracking down these kind of problems is really helpful ;), especially in unusual cases like this one.

best, h