clemos / haxe-sublime-bundle

Sublime Text bundle for Haxe programming language
Apache License 2.0
235 stars 86 forks source link

support windows paths, column number and error message in HXML build system #168

Closed nadako closed 9 years ago

nadako commented 9 years ago

Subj. This changes the file_regex to support windows paths (with : in them) as well as adding groups for column number and error message as documented here: http://docs.sublimetext.info/en/latest/reference/build_systems.html#capturing-error-output-with-file-regex

nadako commented 9 years ago

Actually, it may make more sense to use end character number instead of the first one.

nadako commented 9 years ago

I also added a fix for the regexp in HaxeHelper.compilerOutput as well as extract_errors/highlight_errors so it works on windows for ctrl+enter builds.

nadako commented 9 years ago

aaaand the HaxeHelper.haxeFileRegex

clemos commented 9 years ago

I think the regex used to support line number + column number, but the problem was when the error had no column number (for multiple lines for instance), the regex didn't work at all, and the error was ignored... Can you confirm it works for both cases (single line + column number and multiple lines, no column number) ?

nadako commented 9 years ago

Yeah i tested with "lines", "characters" and "character" cases.

clemos commented 9 years ago

Thanks a lot :)