Fix "file changed on disk" error during autocomplete

clemos / haxe-sublime-bundle

Sublime Text bundle for Haxe programming language

Apache License 2.0

235 stars 86 forks source link

Fix "file changed on disk" error during autocomplete #273

Open kennygoff opened 6 years ago

kennygoff commented 6 years ago

Add a helper function to discern between changed os.stat() api between Python 2 and 3. This should fix "Files changed on disk" popups during auto-complete in #272.

Reference:

os.stat(pathname)[stat.ST_MODE] in Python 3
os.stat(pathname).st_mode in Python 2

kennygoff commented 6 years ago

@clemos I'm still getting some of those changed on disk errors, but I dug into the plugin code and this seemed to fix it, or at least part of the issue. This prevents it from erroring on every change. Hopefully this is a start, will dig into it some more, and can provide more help to debug this now.

Unfortunately I haven't been getting any ST3 console stack traces so until I figure out that, debugging is a pain.

kennygoff commented 6 years ago

I was able to get it working. My original commit was a false positive, unfortunately. Was able to consistently reproduce by completely closing ST3, reopening, then typing one letter after import. This fix is working for me but I am not sure if the block of code I commented out needs to be replaced. So far seems to be able to auto-complete in-file code, packages, etc.

alex-ander-is commented 4 years ago

What is the state of this bug?