clemos / try-haxe

A small webapp that allows to test Haxe online
https://try.haxe.org
MIT License
126 stars 41 forks source link

Invalid reg exp for splitting source to line #132

Closed pleclech closed 7 years ago

pleclech commented 7 years ago

Hello i think the regex here https://github.com/clemos/try-haxe/blob/master/src/SourceTools.hx#L6

is invalid as it split also the line with | and the it should split the \r\n before the other one char line.

You can see it in action here: https://try.haxe.org/#Bdb77

Patrick.

clemos commented 7 years ago

Right :) Could you please make a PR ?

pleclech commented 7 years ago

Done ;)

https://github.com/clemos/try-haxe/pull/133

On 14/04/2017 21:00, Clément Charmet wrote:

Right :) Could you please make a PR ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/clemos/try-haxe/issues/132#issuecomment-294214952, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPILVGNIDcCbLfrpvz-i2j9q7M4NWh_ks5rv8I1gaJpZM4M9_jH.

clemos commented 7 years ago

Your fix is online, thx :)

pleclech commented 7 years ago

You're welcome ;)