search

clemsonMakerspace / CATS

Clemson (Machinery) Access Tracking System
GNU General Public License v3.0
4 stars 9 forks source link

SQL Fix Closes #104 #121

Closed gmross closed 7 years ago

gmross commented 7 years ago

These are the fixes that I managed to pull together based on Owen's comments in #104 (SQL Fixes). I believe this closes the issue(s) addressed.

r3cebarnett commented 7 years ago

Everything that I did can be seen in commit# 42577a7

Okay so I fixed how we get the stuffs from the SQL. There were a few things that were pretty screwy. So now we look up "authType" using "PiHostname" in the SQL, then look up the variable that authType is for ID in user. This is what is returned in machineAuth. For some reason, we had machineAuth returning the current machine, which makes no sense as we try to use it as a boolean later in the program but also as a machinetype in the SQL call in line 54, 55. This is like really stupid and needs to be fixed but I'm more concerned about fixing the algorithm than an event log. @gacosta, @gmross, and I will discuss a better way for us to do this. Also I'd like us to clear up a lot of the formatting for our code. It's very sporadic and all over the place where functions are. It'd be a lot of cleaning to do but I'd really like us to reorganize where we put functions. I found myself searching for a long time trying to find a specific function.

Anyways /rant. @ophilli does this fix the issue you had or do you have any further comments?