clemsonMakerspace / CATS

Clemson (Machinery) Access Tracking System
GNU General Public License v3.0
4 stars 9 forks source link

Create Error logs in SQL Server #45

Closed gacosta1 closed 7 years ago

gacosta1 commented 7 years ago

create a new database that contains error logs with:

First Name Last Name CUID MachineID MachineType Timestamp Error status being: 1 - not authorized, 2 - machine error, 3 - input device not found We can settle this as a team in the next team meeting

gacosta1 commented 7 years ago

Then at the end of the day at 12:00 AM or an automated file will be created with users who tried to use the machine but did not have permission/untrained or machine errors were found or etc.... Food for thought.

ophilli commented 7 years ago

We could call Twillio or Sendgrid to automatically notify admins when authorization fails.

On Thu, Nov 17, 2016 at 9:18 PM, Giandre Acosta notifications@github.com wrote:

Then at the end of the day at 12:00 AM or an automated file will be created with users who tried to use the machine but did not have permission/untrained or machine errors were found or etc.... Food for thought.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_clemsonMakerspace_CATS_issues_45-23issuecomment-2D261430768&d=CwMFaQ&c=Ngd-ta5yRYsqeUsEDgxhcqsYYY1Xs5ogLxWPA_2Wlc4&r=p2VKO7LAm_jqfMnllHihSm4gEiGkkzmU2N7FI2bbmiA&m=i3x7cHwsa3v-jXmpKIXR4UxtVH7JiHFZmCRccIwBpJo&s=-3kTfp1ETvZzwjIfnU0bpwQjvkaz8z49_v1eIjGWxS0&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AA65BnMVo8b7hi9NBBHB2qiyIyPJ9aXiks5q-5FQsHgaJpZM4K14If&d=CwMFaQ&c=Ngd-ta5yRYsqeUsEDgxhcqsYYY1Xs5ogLxWPA_2Wlc4&r=p2VKO7LAm_jqfMnllHihSm4gEiGkkzmU2N7FI2bbmiA&m=i3x7cHwsa3v-jXmpKIXR4UxtVH7JiHFZmCRccIwBpJo&s=dUvEAnp1r1el6-CJ2QfCAGCZqjehiq6eFKdA3aX8Byg&e= .

gacosta1 commented 7 years ago

Yes!! I like that!

r3cebarnett commented 7 years ago

Pretty good idea. I'll quickly make a database for it right now because why not.

On Nov 17, 2016 5:14 PM, "Giandre Acosta" notifications@github.com wrote:

create a new database that contains error logs with:

First Name Last Name CUID MachineID MachineType Timestamp Error status being: 1 - not authorized, 2 - machine error, 3 - input device not found We can settle this as a team in the next team meeting

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/clemsonMakerspace/CATS/issues/45, or mute the thread https://github.com/notifications/unsubscribe-auth/AJqSqJ_o7iOJNtk3XM81j1mwIRJfinkfks5q_NGwgaJpZM4K14If .

ophilli commented 7 years ago

I think this belongs in the Events table. That's what they are - no reason to call a new table for them.

gacosta1 commented 7 years ago

Sweeet thanks Maurice! I created one, but just append to the Events db

ophilli commented 7 years ago

MySQL is a relational database - it's good design to avoid duplicating unnecessary data.

We've already got a table of CUIDs, and MachineIDs. Those contain all the first name, last name, machine type info we need.

I would like to propose the following:

CUID* MachineID* Timestamp* Status
C12345678 001 1970-01-01 00:00:01 1
C23456789 010 1970-01-01 00:00:01 2
C34567890 100 1970-01-01 00:00:01 3

* Denotes Primary Key

gacosta1 commented 7 years ago

Seems clean and straight to the point. I like it. I see it has already been implemented. We're on the right path then.

gacosta1 commented 7 years ago

Error Log for database complete. We just need to figure out what we're going to use to notify the Admin.

ophilli commented 7 years ago

Re-opened pending pull request with code changes that resolve this issue.

ophilli commented 7 years ago

Enhancement implemented in #53