clemsonMakerspace / unified-makerspace

The Makerspace - now unified.
Apache License 2.0
9 stars 11 forks source link

Update accounts_config.py with new Dev usernames and fix error with Windows front-end formatting #114

Closed DillonRanwala closed 2 years ago

DillonRanwala commented 2 years ago

Adding new dev accounts for Fall 2022 to accounts_config file

ophilli commented 2 years ago

You've got 3 commits that all touch the same file with very similar commit messages. Can you please squash those down to one commit?

Please start using https://www.conventionalcommits.org/ for this project too. I know that the previous semester's commits aren't using this and the best time to start would have been at the beginning, but the second best time is today. You can use one of these templates to make this easier in the future.

Commit Message Template Instructions

  1. Copy-paste one of the templates below into a file, such as ~/.gitmessage.
  2. Run git config --global commit.template ~/.gitmessage. (To make it a per-repo setting, omit --global and run it from inside a repo.)

Long Template

# Subject line format:
# <type>(optional scope): <description>
#
# The subject line should make grammatical sense when completing the sentence "If applied, this commit will <subject line>."
# e.g.:
#    fix: round to nearest integer in Percentage.compute()

Problem:

# This is the "why". Describes the specific problem or gap
# that is being addressed by the change. Clearly stating the problem
# also makes it easier for others to assess the effectiveness and
# suitability of the provided solution.

Solution:

# This is the "what", *not* the "how". Describe the changes
# in detail and explain how they solve the problem.

Testing:

# Describes what was done to verify that the solution actually
# solves the problem.

Issue:

# Link/reference to a GitHub Issue, Trello Issue, etc
# e.g.:
#    Issue: #101
# or:
#    Issue: https://github.com/clemsonMakerspace/unified-makerspace/issues/101

# Types Reference:
# build    | Builds                   | Changes that affect the build system or external dependencies.
# ci       | Continuous Integrations  | Changes that affect the CI configuration files and scripts.
# chore    | Chores                   | Other changes that don't modify src or test files.
# docs     | Documentation            | Documentation only changes.
# feat     | Features                 | A new feature.
# fix      | Bug Fixes                | A bug fix.
# perf     | Performance Improvements | A code change that improves performance.
# refactor | Code Refactoring         | A code change that neither fixes a bug nor adds a feature.
# revert   | Reverts                  | Reverts a previous commit
# style    | Styles                   | Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc).
# test     | Tests                    | Adding missing tests or correcting existing tests.

# On BREAKING CHANGES:
# Commit messages MUST include both "!" in the subject type and "BREAKING CHANGE: ..." in the body when a commit has breaking changes.
# e.g.:
#
#    feat!: drop support for API v2
#
#    BREAKING CHANGE: Remove support for API v2 because it has been
#    deprecating for 3yrs and there are no known clients connecting.

# Example:
#
#    fix: round to nearest integer in Percentage.compute()
# 
#    Problem:
#
#    The compute method was incorrectly truncating the return value.
#    Per the API description it should be rounded to the nearest
#    integer value.
# 
#    Solution:
#
#    The change fixes the issue by using the round() function to round
#    the value prior to casting to an integer.
#  
#    Testing:
#
#    A unit test was added to cover this scenario; it fails with the older
#    code but passes with the fix.
#  
#    Issue: #101

Short Template

<type>(optional scope): <description>
# Types: build ci chore docs feat fix perf refactor revert style test

Problem: <description>

Solution: <description>

Testing: <description>

Issue: <GitHub issue number or URL>

Also, this branch cannot be rebased at the moment due to conflicts. Please update the PR & then I'll review again.