search

clemsonMakerspace / unified-makerspace

The Makerspace - now unified.
Apache License 2.0
8 stars 11 forks source link

feat(cdk/visit/lambda_code): add print statement for monitoring #125

Closed DillonRanwala closed 1 year ago

DillonRanwala commented 1 year ago

Problem: Successful lambda canary tests do not have any print statements that show up in the Cloudwatch logs for the TestAPI Lambda. It can be difficult to determine which logs contain successful test runs.

Solution: By adding this print statement, the Cloudwatch logs should display the time and username for any successful tests.

Testing: By adding this print statement in dev instances, the lambda functionality was not affected.

Issue: N/A, No open issue.

ophilli commented 1 year ago

@DillonRanwala when you updated the commit message it looks like you added a second commit instead of amending the first one. I'm going to squash & merge this PR which will clean that up a little bit, but in the future can you try to amend your commits so that if we rebase and merge the commit log will be exactly how you want it?

I'm not sure how trivial that is to do on GitHub. If it's a huge pain please let me know.

DillonRanwala commented 1 year ago

I see, I tried editing the message through Github, but I suppose that created a new commit. I will keep this in mind for any future pull requests, thanks for letting me know.